Skip to content

[Synthetics] Should this promise be retried? #182287

Open

Description

The promises below might fail in case there's a glitch in ES connection and never retry.

this.syntheticsService.setup(plugins.taskManager).catch(() => {});

this.telemetryEventsSender.start(pluginsStart.telemetry, coreStart).catch(() => {});

defaultAlertService
.setupDefaultAlerts()
.then(() => {
server.logger.debug(`Successfully created default alert for monitor: ${name}`);
})
.catch((error) => {
server.logger.error(`Error creating default alert: ${error} for monitor: ${name}`);
});

Is that OK? Should we apply any retry logic?

If we want to retry, p-retry could be a useful utility that's already present in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    SyntheticsTeam:obs-ux-managementObservability Management User Experience Teamtechnical debtImprovement of the software architecture and operational architecture

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions