Skip to content

[management][settings] Replace prop drilling of settings changes with Redux. #166579

Open

Description

The functional flow logic we've adopted for @kbn/management-settings components is not one I would encourage. Specifically, these components use "drilled" onChange handlers that pass changes up to a component-based store, then back down to the input component.

In the interest of time and compatibility, we've opted to use this pattern from the original components in advancedSettings. We need to revisit the state management and prop-drilling when we replace the application in the advancedSettingsplugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Feature:Kibana ManagementFeature label for Data Views, Advanced Setting, Saved Object management pagesTeam:Kibana ManagementDev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and moreTeam:SharedUXTeam label for AppEx-SharedUX (formerly Global Experience)technical debtImprovement of the software architecture and operational architecture

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions