Skip to content

Management plugin should handle share as an optional dependency #144457

Open

Description

Problem
Management plugin declares share as an optional dependency, but does not handle a use-case when it's not supplied. This was not an issue until now as probably the start order of plugins was such that all plugins had this as a dependency as well. However, when creating a new plugin with "management" as a dependency, this was causing an error on Kibana start:

TypeError: Cannot read properties of undefined (reading 'url')
    at ManagementPlugin.setup (plugin.ts:42:1)

coming from:
https://github.com/elastic/kibana/blob/main/src/plugins/management/public/plugin.ts#L78

This was mitigated in: #144381 by making "share" a required dependency, but I assume you would like a proper fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Feature:Kibana ManagementFeature label for Data Views, Advanced Setting, Saved Object management pagesTeam:Kibana ManagementDev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and morebugFixes for quality problems that affect the customer experience

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions