Open
Description
openedon Mar 28, 2022
Similar like we did to low level SQL strategy, we should clean up EQL search strategy and align it with other async strategies:
Ideally we should do it before wider adoption in Kibana (unified search).
Here is the list of possible alignment things:
- Is it Required to return both headers + body in the response? . Can we do body + warning as in other strategies?
- Can we better type it using
EqlSearchResponse
? - Don't use deprecatated
typesWithBodyKey
format - Type search request with
EqlSearchRequest
andEqlGetRequest
- Don't provide unsupported by strategies params / options to avoid ts-ignore: . Make params explicit
- Properly use submit / get async utils
- Add example plugin
- Add function test for example plugin
- Add API test for search strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Querying infrastructure in KibanaDiscover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)Addressing this issue will have a low level of impact on the quality/strength of our product.Medium Level of EffortImprovement of the software architecture and operational architecture