Skip to content

[App Services] Expand API to allow communication from plugins to the TopNavMenu #124062

Closed as not planned
@Heenawter

Description

Describe the feature:

Right now, communication between the TopNavMenu and any plugins that use it is more-or-less in a single direction - specifically, the TopNavMenu communicates to the plugin and controls its inner state. However, as part of adding in-product help to Discover, it was discovered (:wink:) that there are certain use cases where the ability to trigger events in the TopNavMenu from within a plugin might be desired - for example, allowing a link inside of Discover to open the SuperDatePicker

Describe a specific use case for the feature:

Right now, the empty state of Discover has three suggestions for users to help them see their data:

image

Notice that the final suggestion (Try temporarily disabling filters.) has an action attached that will disable all filters - in order to improve the empty state, it would be awesome to attach actions to the other two suggestion, as well:

  1. The action for the Try searching over a longer period of time. suggestion would open the SuperDatePicker.
  2. The action for the Try searching for a different combination of terms. would open the query bar or maybe even clear it.

However, in order to do this properly, Discover would need to be able to trigger the appropriate onClick actions in TopNavMenu.

⭐ Click here for a PR that includes a demo of how this could improve Discover's empty state

Metadata

Assignees

No one assigned

    Labels

    Team:PresentationPresentation Team for Dashboard, Input Controls, and Canvasdiscussimpact:mediumAddressing this issue will have a medium level of impact on the quality/strength of our product.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions