Closed
Description
openedon Jun 22, 2021
Kibana version: master
PR #102782 failed CI on the Jest integration tests step with:
16:17:49 Summary of all failing tests
16:17:49 FAIL src/core/server/saved_objects/migrationsv2/integration_tests/migration.test.ts (126.196 s)
16:17:49
16:17:49
16:17:49 ● Test suite failed to run
16:17:49
16:17:49 TypeError: Cannot read property 'append' of undefined
16:17:49
16:17:49 52 |
16:17:49 53 | for (const appender of this.appenders) {
16:17:49 > 54 | appender.append(record);
16:17:49 | ^
16:17:49 55 | }
16:17:49 56 | }
16:17:49 57 |
16:17:49
16:17:49 at BaseLogger.log (src/core/server/logging/logger.ts:54:16)
16:17:49 at BaseLogger.info (src/core/server/logging/logger.ts:33:10)
16:17:49 at LoggerAdapter.info (src/core/server/logging/logger_adapter.ts:36:17)
16:17:49 at LevelLogger.info (x-pack/plugins/reporting/server/lib/level_logger.ts:58:26)
16:17:49 at backgroundInstall (x-pack/plugins/reporting/server/browsers/install.ts:50:12)
which is caused by reporting plugin logging after Kibana stops.
There are 2 problems:
- Reporting plugin doesn't interrupt the installation process when Kibana stopped
- Reporting runs installation when unnecessary.
I fixed the problem by disabling the reporting plugin in this specific case, but it's rather a workaround.
@elastic/kibana-reporting-services is it possible to install a browser in dev mode by a request?
if no, @elastic/kibana-operations should we disable the reporting plugin by default in all the integration tests with oss: false? tbh, I'd like to avoid that because it means dev and test configuration diverge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment