Skip to content

[Alerting][Actions] Action parameters are not validated on rule creation #101090

Open

Description

When the action executor runs, action parameters are validated against the parameter schema and an error is thrown when there is an invalid parameter. However, when a rule is created with actions, those action parameters are not validated. This means a rule with actions could be created successfully, but when the rule is triggered and its actions run, the actions will throw an error.

To create this scenario, create a rule with a Pagerduty action through the API and set the timestamp field to null in the action parameters. The rule creation returns a 200 but the first time the action tries to run, you will see logs like these:

Task actions:.pagerduty "e47b5ae0-c30e-11eb-83e4-695f9fbb4810" failed: Error: error validating action params: [timestamp]: expected value of type [string] but got [null]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Feature:AlertingFeature:Alerting/RuleActionsIssues related to the Actions attached to Rules on the Alerting FrameworkFeature:Alerting/RulesManagementIssues related to the Rules Management UXTeam:ResponseOpsLabel for the ResponseOps team (formerly the Cases and Alerting teams)estimate:smallSmall Estimated Level of EffortresilienceIssues related to Platform resilience in terms of scale, performance & backwards compatibility

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions