Skip to content

Commit

Permalink
[8.15] [ML] Transforms: Pagination in the source documents data grid …
Browse files Browse the repository at this point in the history
…fix (#196119) (#196814)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML] Transforms: Pagination in the source documents data grid fix
(#196119)](#196119)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-14T15:01:36Z","message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Transforms","v9.0.0","Team:ML","v8.16.0","backport:version","v8.15.4"],"title":"[ML]
Transforms: Pagination in the source documents data grid
fix","number":196119,"url":"https://github.com/elastic/kibana/pull/196119","mergeCommit":{"message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196119","number":196119,"mergeCommit":{"message":"[ML]
Transforms: Pagination in the source documents data grid fix
(#196119)\n\n## Summary\r\n\r\nFix for:
[#195881](https://github.com/elastic/kibana/issues/195881)\r\n\r\nAfter:\r\nIt's
hardly visible in the recording, but if you look at the\r\n`@timestamp`
column, you can see that the values are changing correctly\r\nwhile
navigating to a previous page, which was not the case before
the\r\nfix.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de","sha":"1489396c84356fb6226290438ce805c209ef650a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196163","number":196163,"state":"MERGED","mergeCommit":{"sha":"828133d7ed029e82caea98af9c83ed1b4a57f1b9","message":"[8.x]
[ML] Transforms: Pagination in the source documents data grid fix
(#196119) (#196163)\n\n# Backport\n\nThis will backport the following
commits from `main` to `8.x`:\n- [[ML] Transforms: Pagination in the
source documents data grid
fix\n(#196119)](https://github.com/elastic/kibana/pull/196119)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Robert\nJaszczurek\",\"email\":\"92210485+rbrtj@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-10-14T15:01:36Z\",\"message\":\"[ML]\nTransforms:
Pagination in the source documents data grid fix\n(#196119)\\n\\n##
Summary\\r\\n\\r\\nFix
for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly
visible in the recording, but if you look at
the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing
correctly\\r\\nwhile\nnavigating to a previous page, which was not the
case
before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"backport\npending\",\":ml\",\"Feature:Transforms\",\"v9.0.0\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]\nTransforms:
Pagination in the source documents data
grid\nfix\",\"number\":196119,\"url\":\"https://github.com/elastic/kibana/pull/196119\",\"mergeCommit\":{\"message\":\"[ML]\nTransforms:
Pagination in the source documents data grid fix\n(#196119)\\n\\n##
Summary\\r\\n\\r\\nFix
for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly
visible in the recording, but if you look at
the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing
correctly\\r\\nwhile\nnavigating to a previous page, which was not the
case
before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196119\",\"number\":196119,\"mergeCommit\":{\"message\":\"[ML]\nTransforms:
Pagination in the source documents data grid fix\n(#196119)\\n\\n##
Summary\\r\\n\\r\\nFix
for:\n[#195881](https://github.com/elastic/kibana/issues/195881)\\r\\n\\r\\nAfter:\\r\\nIt's\nhardly
visible in the recording, but if you look at
the\\r\\n`@timestamp`\ncolumn, you can see that the values are changing
correctly\\r\\nwhile\nnavigating to a previous page, which was not the
case
before\nthe\\r\\nfix.\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/33be9e8c-e558-4f48-994a-562c4e3788de\",\"sha\":\"1489396c84356fb6226290438ce805c209ef650a\"}},{\"branch\":\"8.x\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v8.16.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Robert Jaszczurek
<92210485+rbrtj@users.noreply.github.com>"}},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
  • Loading branch information
kibanamachine and rbrtj authored Oct 18, 2024
1 parent 175c1d0 commit f7a0fea
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export const useIndexData = (
setStatus(INDEX_STATUS.LOADED);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [dataGridDataError, dataGridDataIsError, dataGridDataIsLoading]);
}, [dataGridDataError, dataGridDataIsError, dataGridDataIsLoading, dataGridData]);

const allDataViewFieldNames = new Set(dataView.fields.map((f) => f.name));
const { error: histogramsForFieldsError, data: histogramsForFieldsData } =
Expand Down

0 comments on commit f7a0fea

Please sign in to comment.