[transform] Review feedback: Fix texts.

Author: walterra

x-pack/legacy/plugins/transform/public/app/common/navigation.tsx

@@ -12,7 +12,7 @@ import { CLIENT_BASE_PATH, SECTION_SLUG } from '../constants';
 
 /**
  * Gets a url for navigating to Discover page.
- * @param indexPatternId Index pattern id.
+ * @param indexPatternId Index pattern ID.
  * @param baseUrl Base url.
  */
 export function getDiscoverUrl(indexPatternId: string, baseUrl: string): string {

x-pack/legacy/plugins/transform/public/app/common/transform.test.ts

@@ -7,22 +7,22 @@
 import { isTransformIdValid } from './transform';
 
 describe('Transform: isTransformIdValid()', () => {
-  test('returns true for job id: "good_job-name"', () => {
+  test('returns true for job ID: "good_job-name"', () => {
     expect(isTransformIdValid('good_job-name')).toBe(true);
   });
-  test('returns false for job id: "_bad_job-name"', () => {
+  test('returns false for job ID: "_bad_job-name"', () => {
     expect(isTransformIdValid('_bad_job-name')).toBe(false);
   });
-  test('returns false for job id: "bad_job-name_"', () => {
+  test('returns false for job ID: "bad_job-name_"', () => {
     expect(isTransformIdValid('bad_job-name_')).toBe(false);
   });
-  test('returns false for job id: "-bad_job-name"', () => {
+  test('returns false for job ID: "-bad_job-name"', () => {
     expect(isTransformIdValid('-bad_job-name')).toBe(false);
   });
-  test('returns false for job id: "bad_job-name-"', () => {
+  test('returns false for job ID: "bad_job-name-"', () => {
     expect(isTransformIdValid('bad_job-name-')).toBe(false);
   });
-  test('returns false for job id: "bad&job-name"', () => {
+  test('returns false for job ID: "bad&job-name"', () => {
     expect(isTransformIdValid('bad&job-name')).toBe(false);
   });
 });

x-pack/legacy/plugins/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx

@@ -88,7 +88,7 @@ export const StepDetailsForm: SFC<Props> = React.memo(({ overrides = {}, onChang
         } catch (e) {
           toastNotifications.addDanger(
             i18n.translate('xpack.transform.stepDetailsForm.errorGettingTransformList', {
-              defaultMessage: 'An error occurred getting the existing transform Ids: {error}',
+              defaultMessage: 'An error occurred getting the existing transform IDs: {error}',
               values: { error: JSON.stringify(e) },
             })
           );
@@ -181,7 +181,7 @@ export const StepDetailsForm: SFC<Props> = React.memo(({ overrides = {}, onChang
     <EuiForm>
       <EuiFormRow
         label={i18n.translate('xpack.transform.stepDetailsForm.transformIdLabel', {
-          defaultMessage: 'Transform id',
+          defaultMessage: 'Transform ID',
         })}
         isInvalid={(!transformIdEmpty && !transformIdValid) || transformIdExists}
         error={[
@@ -196,18 +196,18 @@ export const StepDetailsForm: SFC<Props> = React.memo(({ overrides = {}, onChang
           ...(transformIdExists
             ? [
                 i18n.translate('xpack.transform.stepDetailsForm.transformIdExistsError', {
-                  defaultMessage: 'A transform with this id already exists.',
+                  defaultMessage: 'A transform with this ID already exists.',
                 }),
               ]
             : []),
         ]}
       >
         <EuiFieldText
-          placeholder="transform id"
+          placeholder="transform ID"
           value={transformId}
           onChange={e => setTransformId(e.target.value)}
           aria-label={i18n.translate('xpack.transform.stepDetailsForm.transformIdInputAriaLabel', {
-            defaultMessage: 'Choose a unique transform id.',
+            defaultMessage: 'Choose a unique transform ID.',
           })}
           isInvalid={(!transformIdEmpty && !transformIdValid) || transformIdExists}
         />

x-pack/legacy/plugins/transform/public/app/sections/create_transform/components/step_details/step_details_summary.tsx

@@ -36,7 +36,7 @@ export const StepDetailsSummary: SFC<StepDetailsExposedState> = React.memo(
       <Fragment>
         <EuiFormRow
           label={i18n.translate('xpack.transform.stepDetailsSummary.transformIdLabel', {
-            defaultMessage: 'Transform id',
+            defaultMessage: 'Transform ID',
           })}
         >
           <EuiFieldText defaultValue={transformId} disabled={true} />

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/__snapshots__/expanded_row.test.tsx.snap

@@ -60,14 +60,14 @@ export const StartAction: FC<StartActionProps> = ({ items, forceDisable }) => {
     startedTransformMessage = i18n.translate(
       'xpack.transform.transformList.startedTransformBulkToolTip',
       {
-        defaultMessage: 'One or more selected transforms is already started.',
+        defaultMessage: 'One or more transforms are already started.',
       }
     );
     completedBatchTransformMessage = i18n.translate(
       'xpack.transform.transformList.completeBatchTransformBulkActionToolTip',
       {
         defaultMessage:
-          'One or more selected transforms is a completed batch transform and cannot be restarted.',
+          'One or more transforms are completed batch transforms and cannot be restarted.',
       }
     );
   } else {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/action_start.tsx

@@ -38,7 +38,7 @@ export const StopAction: FC<StopActionProps> = ({ items, forceDisable }) => {
     stoppedTransformMessage = i18n.translate(
       'xpack.transform.transformList.stoppedTransformBulkToolTip',
       {
-        defaultMessage: 'One or more selected transforms is already stopped.',
+        defaultMessage: 'One or more transforms are already stopped.',
       }
     );
   } else {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/action_stop.tsx

@@ -43,7 +43,7 @@ export const ExpandedRow: SFC<Props> = ({ item }) => {
   const stateItems: Item[] = [];
   stateItems.push(
     {
-      title: 'id',
+      title: 'ID',
       description: item.id,
     },
     {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/expanded_row.tsx

@@ -138,7 +138,7 @@ export const TransformList: FC<Props> = ({
 
       if (c.type === 'term') {
         // filter term based clauses, e.g. bananas
-        // match on id and description
+        // match on ID and description
         // if the term has been negated, AND the matches
         if (bool === true) {
           ts = transforms.filter(