[transform] Fix types, tests.

Author: walterra

x-pack/legacy/plugins/transform/public/app/app.tsx

@@ -14,7 +14,7 @@ import { SectionError } from './components';
 import { CLIENT_BASE_PATH, SECTION_SLUG } from './constants';
 import { getAppProviders } from './app_dependencies';
 import { AuthorizationContext } from './lib/authorization';
-import { AppCore, AppPlugins } from './types';
+import { AppDependencies } from '../shim';
 
 import { CreateTransformSection } from './sections/create_transform';
 import { TransformManagementSection } from './sections/transform_management';
@@ -54,8 +54,8 @@ export const App: FC = () => {
   );
 };
 
-export const renderReact = (elem: Element, core: AppCore, plugins: AppPlugins) => {
-  const Providers = getAppProviders({ core, plugins });
+export const renderReact = (elem: Element, appDependencies: AppDependencies) => {
+  const Providers = getAppProviders(appDependencies);
 
   render(
     <Providers>

x-pack/legacy/plugins/transform/public/app/app_dependencies.tsx

@@ -9,7 +9,7 @@ import { HashRouter } from 'react-router-dom';
 
 import { API_BASE_PATH } from '../../common/constants';
 import { AuthorizationProvider } from './lib/authorization';
-import { AppDependencies } from './types';
+import { AppDependencies } from '../shim';
 
 let DependenciesContext: React.Context<AppDependencies>;
 

x-pack/legacy/plugins/transform/public/app/lib/kibana/kibana_provider.tsx

@@ -30,7 +30,7 @@ interface Props {
 
 export const KibanaProvider: FC<Props> = ({ savedObjectId, children }) => {
   const appDeps = useAppDependencies();
-  const savedSearches = appDeps.core.savedSearches.getClient();
+  const savedSearches = appDeps.plugins.savedSearches.getClient();
 
   const [contextValue, setContextValue] = useState<KibanaContextValue>({ initialized: false });
 

x-pack/legacy/plugins/transform/public/app/types/app.ts

@@ -12,7 +12,6 @@ import { SavedSearchLoader } from '../../../../../src/legacy/core_plugins/kibana
 import { PLUGIN } from '../common/constants';
 import { CLIENT_BASE_PATH } from './app/constants';
 import { renderReact } from './app/app';
-import { AppCore, AppPlugins } from './app/types';
 import { Core, Plugins } from './shim';
 
 import { breadcrumbService, docTitleService } from './app/services/navigation';
@@ -30,6 +29,15 @@ export class Plugin {
     const { http, routing, legacyHttp, chrome, documentation, docTitle } = core;
     const { management, savedSearches: coreSavedSearches, uiMetric } = plugins;
 
+    // AppCore/AppPlugins to be passed on as React context
+    const AppDependencies = {
+      core: { chrome, http, i18n: core.i18n },
+      plugins: {
+        management: { sections: management.sections },
+        savedSearches: coreSavedSearches,
+      },
+    };
+
     // Register management section
     const esSection = management.sections.getSection('elasticsearch');
     esSection.register(PLUGIN.ID, {
@@ -101,11 +109,7 @@ export class Plugin {
           unmountReactApp();
           const elem = document.getElementById(REACT_ROOT_ID);
           if (elem) {
-            renderReact(
-              elem,
-              { chrome, http, savedSearches: coreSavedSearches } as AppCore,
-              { management: { sections: management.sections } } as AppPlugins
-            );
+            renderReact(elem, AppDependencies);
           }
         });
       },

x-pack/legacy/plugins/transform/public/app/types/index.ts

@@ -14,12 +14,25 @@ import { docTitle } from 'ui/doc_title/doc_title';
 import { createUiStatsReporter } from '../../../../../src/legacy/core_plugins/ui_metric/public';
 import { SavedSearchLoader } from '../../../../../src/legacy/core_plugins/kibana/public/discover/types';
 
-type npCore = typeof npStart.core;
+export type npCore = typeof npStart.core;
+
+// AppCore/AppPlugins is the set of core features/plugins
+// we pass on via context/hooks to the app and its components.
+export type AppCore = Pick<npCore, 'chrome' | 'http' | 'i18n'>;
 
 export interface AppPlugins {
   management: {
     sections: typeof management;
   };
+  savedSearches: {
+    getClient(): any;
+    setClient(client: any): void;
+  };
+}
+
+export interface AppDependencies {
+  core: AppCore;
+  plugins: AppPlugins;
 }
 
 export interface Core extends npCore {
@@ -47,10 +60,6 @@ export interface Plugins extends AppPlugins {
       BREADCRUMB: typeof MANAGEMENT_BREADCRUMB;
     };
   };
-  savedSearches: {
-    getClient(): any;
-    setClient(client: any): void;
-  };
   uiMetric: {
     createUiStatsReporter: typeof createUiStatsReporter;
   };

x-pack/legacy/plugins/transform/public/plugin.ts

@@ -280,7 +280,6 @@ export default function({ getService }: FtrProviderContext) {
     after(async () => {
       await esArchiver.unload('ml/farequote');
       await ml.api.cleanMlIndices();
-      await ml.api.cleanDataframeIndices();
     });
 
     for (const testData of testDataList) {