Skip to content

Commit

Permalink
Relocating module @kbn/core-base-common
Browse files Browse the repository at this point in the history
  • Loading branch information
gsoldevila committed Dec 23, 2024
1 parent 2739513 commit c9d1a2f
Show file tree
Hide file tree
Showing 15 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ packages/core/analytics/core-analytics-server-mocks @elastic/kibana-core
packages/core/application/core-application-browser-mocks @elastic/kibana-core
packages/core/apps/core-apps-browser-mocks @elastic/kibana-core
packages/core/base/core-base-browser-mocks @elastic/kibana-core
packages/core/base/core-base-common @elastic/kibana-core
packages/core/base/core-base-common-internal @elastic/kibana-core
packages/core/base/core-base-server-internal @elastic/kibana-core
packages/core/base/core-base-server-mocks @elastic/kibana-core
Expand Down Expand Up @@ -557,6 +556,7 @@ src/core/packages/application/common @elastic/kibana-core
src/core/packages/apps/browser-internal @elastic/kibana-core
src/core/packages/apps/server-internal @elastic/kibana-core
src/core/packages/base/browser-internal @elastic/kibana-core
src/core/packages/base/common @elastic/kibana-core
src/core/packages/core @elastic/kibana-core
src/platform/packages/private/default-nav/devtools @elastic/kibana-management
src/platform/packages/private/default-nav/management @elastic/kibana-management
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@
"@kbn/core-apps-browser-internal": "link:src/core/packages/apps/browser-internal",
"@kbn/core-apps-server-internal": "link:src/core/packages/apps/server-internal",
"@kbn/core-base-browser-internal": "link:src/core/packages/base/browser-internal",
"@kbn/core-base-common": "link:packages/core/base/core-base-common",
"@kbn/core-base-common": "link:src/core/packages/base/common",
"@kbn/core-base-common-internal": "link:packages/core/base/core-base-common-internal",
"@kbn/core-base-server-internal": "link:packages/core/base/core-base-server-internal",
"@kbn/core-capabilities-browser-internal": "link:packages/core/capabilities/core-capabilities-browser-internal",
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-relocate/utils/relocate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ const replaceReferencesInternal = async (

let d = dst;
// For .bazel references, we need to keep the original name reference if we are renaming the path
// For example, in the move "packages/core/base/core-base-common" to "src/core/packages/base/common",
// For example, in the move "src/core/packages/base/common" to "src/core/packages/base/common",
// we need to keep the reference name to core-base-common by replacing it with "src/core/packages/base/common:core-base-common"
if (
file.endsWith('.bazel') &&
Expand Down
2 changes: 1 addition & 1 deletion packages/react/kibana_context/root/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ DEPS = [
"@npm//react",
"@npm//tslib",
"@npm//@elastic/eui",
"//packages/core/base/core-base-common",
"//src/core/packages/base/common:core-base-common",
"//packages/shared-ux/router/impl:shared-ux-router",
]

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@

module.exports = {
preset: '@kbn/test/jest_node',
rootDir: '../../../..',
roots: ['<rootDir>/packages/core/base/core-base-common'],
rootDir: '../../../../..',
roots: ['<rootDir>/src/core/packages/base/common'],
};
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../../tsconfig.base.json",
"extends": "../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
"types": [
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,8 @@
"@kbn/core-base-browser-internal/*": ["src/core/packages/base/browser-internal/*"],
"@kbn/core-base-browser-mocks": ["packages/core/base/core-base-browser-mocks"],
"@kbn/core-base-browser-mocks/*": ["packages/core/base/core-base-browser-mocks/*"],
"@kbn/core-base-common": ["packages/core/base/core-base-common"],
"@kbn/core-base-common/*": ["packages/core/base/core-base-common/*"],
"@kbn/core-base-common": ["src/core/packages/base/common"],
"@kbn/core-base-common/*": ["src/core/packages/base/common/*"],
"@kbn/core-base-common-internal": ["packages/core/base/core-base-common-internal"],
"@kbn/core-base-common-internal/*": ["packages/core/base/core-base-common-internal/*"],
"@kbn/core-base-server-internal": ["packages/core/base/core-base-server-internal"],
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4345,7 +4345,7 @@
version "0.0.0"
uid ""

"@kbn/core-base-common@link:packages/core/base/core-base-common":
"@kbn/core-base-common@link:src/core/packages/base/common":
version "0.0.0"
uid ""

Expand Down

0 comments on commit c9d1a2f

Please sign in to comment.