Skip to content

Commit

Permalink
[Dataset quality] - Enable links to Dataset Quality from Management a…
Browse files Browse the repository at this point in the history
…nd Logs Explorer (#186143)

Add links to Dataset Quality in the following places:
1. "Data sets" link on Logs Explorer nav header (on both Serverless and
Stateful)
2. "Data Set Quality" side nav menu item under Stack Management -> Data
(Stateful)
3. "Data Set Quality" card under Management -> Data (Serverless)

On Logs Explorer - Stateful

![dataset-quality-logs-explorer-link-stateful](https://github.com/elastic/kibana/assets/2748376/ea9b37ef-abfd-433d-97d2-ee678d679aa3)

On Logs Explorer - Serverless

![dataset-quality-logs-explorer-link-serverless](https://github.com/elastic/kibana/assets/2748376/6fac1e8a-9ff5-423d-bacb-5a777158c30d)

Stack Management - Stateful

![dataset-quality-side-nav-stateful-link](https://github.com/elastic/kibana/assets/2748376/3561047d-5f65-469d-bfd1-c235058b71ac)

Stack Management - Serverless

![image](https://github.com/elastic/kibana/assets/2748376/a4182040-8565-4ad9-9ef2-909e0161ce78)

---------

Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
  • Loading branch information
awahab07 and yngrdyn authored Jun 28, 2024
1 parent 41817d0 commit b9c903b
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 5 deletions.
7 changes: 7 additions & 0 deletions packages/kbn-management/cards_navigation/src/consts.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ export const appDefinitions: Record<AppId, AppDefinition> = {
}),
icon: 'logstashQueue',
},
[AppIds.DATA_QUALITY]: {
category: appCategories.DATA,
description: i18n.translate('management.landing.withCardNavigation.dataQualityDescription', {
defaultMessage: 'Find and manage quality issues in your log data.',
}),
icon: 'documents',
},

[AppIds.RULES]: {
category: appCategories.ALERTS,
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-management/cards_navigation/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export enum AppIds {
SERVERLESS_SETTINGS = 'settings',
ROLES = 'roles',
API_KEYS = 'api_keys',
DATA_QUALITY = 'data_quality',
}

// Create new type that is a union of all the appId values
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/data_quality/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class DataQualityPlugin

return renderApp(coreStart, pluginsStartDeps, pluginStart, params);
},
hideFromSidebar: true,
hideFromSidebar: false,
});

const managementLocator =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@ export const createSLoLabel = i18n.translate('xpack.observabilityLogsExplorer.cr
export const datasetQualityLinkTitle = i18n.translate(
'xpack.observabilityLogsExplorer.datasetQualityLinkTitle',
{
defaultMessage: 'Datasets',
defaultMessage: 'Data sets',
}
);
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"observabilityShared",
"slo",
"share",
"kibanaUtils"
"kibanaUtils",
"dataQuality"
],
"optionalPlugins": [
"serverless",
Expand All @@ -35,7 +36,7 @@
"triggersActionsUi"
],
"extraPublicDirs": [
"common",
"common"
]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { ConnectedDiscoverLink } from './discover_link';
import { FeedbackLink } from './feedback_link';
import { ConnectedOnboardingLink } from './onboarding_link';
import { AlertsPopover } from './alerts_popover';
import { ConnectedDatasetQualityLink } from './dataset_quality_link';

export const LogsExplorerTopNavMenu = () => {
const {
Expand Down Expand Up @@ -70,6 +71,8 @@ const ProjectTopNav = () => {
<EuiHeaderLinks gutterSize="xs">
<ConnectedDiscoverLink />
<VerticalRule />
<ConnectedDatasetQualityLink />
<VerticalRule />
<FeedbackLink />
<VerticalRule />
<AlertsPopover />
Expand Down Expand Up @@ -145,6 +148,8 @@ const ClassicTopNav = () => {
<EuiHeaderLinks gutterSize="xs">
<ConnectedDiscoverLink />
<VerticalRule />
<ConnectedDatasetQualityLink />
<VerticalRule />
<AlertsPopover />
<VerticalRule />
<ConnectedOnboardingLink />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
expect(sections).to.have.length(2);
expect(sections[0]).to.eql({
sectionId: 'data',
sectionLinks: ['index_management', 'transform'],
sectionLinks: ['index_management', 'data_quality', 'transform'],
});
});
});
Expand Down

0 comments on commit b9c903b

Please sign in to comment.