[ML] Revert ml data test subj/class name changes

qn895 · qn895 · commit aaf142c7ebdd · 2021-06-07T11:13:39.000-05:00
diff --git a/x-pack/plugins/ml/public/application/components/data_grid/column_chart.scss b/x-pack/plugins/ml/public/application/components/data_grid/column_chart.scss
@@ -1,9 +1,9 @@
-.dataVisualizerDataGridChart__histogram {
+.mlDataGridChart__histogram {
   width: 100%;
   height: $euiSizeXL + $euiSizeXXL;
 }
 
-.dataVisualizerDataGridChart__legend {
+.mlDataGridChart__legend {
   @include euiTextTruncate;
   @include euiFontSizeXS;
 
@@ -16,11 +16,11 @@
   text-align: left;
 }
 
-.dataVisualizerDataGridChart__legend--numeric {
+.mlDataGridChart__legend--numeric {
   text-align: right;
 }
 
-.dataVisualizerDataGridChart__legendBoolean {
+.mlDataGridChart__legendBoolean {
   width: 100%;
   min-width: $euiButtonMinWidth;
   td { text-align: center }
diff --git a/x-pack/plugins/ml/public/application/components/data_grid/column_chart.tsx b/x-pack/plugins/ml/public/application/components/data_grid/column_chart.tsx
@@ -53,10 +53,7 @@ export const ColumnChart: FC<Props> = ({
   return (
     <div data-test-subj={dataTestSubj}>
       {!isUnsupportedChartData(chartData) && data.length > 0 && (
-        <div
-          className="dataVisualizerDataGridChart__histogram"
-          data-test-subj={`${dataTestSubj}-histogram`}
-        >
+        <div className="mlDataGridChart__histogram" data-test-subj={`${dataTestSubj}-histogram`}>
           <Chart>
             <Settings theme={columnChartTheme} />
             <BarSeries
@@ -73,9 +70,9 @@ export const ColumnChart: FC<Props> = ({
         </div>
       )}
       <div
-        className={classNames('dataVisualizerDataGridChart__legend', {
+        className={classNames('mlDataGridChart__legend', {
           // eslint-disable-next-line @typescript-eslint/naming-convention
-          'dataVisualizerDataGridChart__legend--numeric': columnType.schema === 'number',
+          'mlDataGridChart__legend--numeric': columnType.schema === 'number',
         })}
         data-test-subj={`${dataTestSubj}-legend`}
       >
diff --git a/x-pack/plugins/ml/public/application/components/data_grid/use_column_chart.tsx b/x-pack/plugins/ml/public/application/components/data_grid/use_column_chart.tsx
@@ -94,7 +94,7 @@ export const getLegendText = (
 
   if (chartData.type === 'boolean') {
     return (
-      <table className="dataVisualizerDataGridChart__legendBoolean">
+      <table className="mlDataGridChart__legendBoolean">
         <tbody>
           <tr>
             {chartData.data[0] !== undefined && <td>{chartData.data[0].key_as_string}</td>}
diff --git a/x-pack/plugins/ml/public/application/components/data_grid/use_data_grid.tsx b/x-pack/plugins/ml/public/application/components/data_grid/use_data_grid.tsx
@@ -113,7 +113,7 @@ export const useDataGrid = (
             <ColumnChart
               chartData={chartData}
               columnType={c}
-              dataTestSubj={`dataVisualizerDataGridChart-${c.id}`}
+              dataTestSubj={`mlDataGridChart-${c.id}`}
             />
           ) : undefined,
       };
diff --git a/x-pack/plugins/ml/public/application/components/ml_embedded_map/_ml_embedded_map.scss b/x-pack/plugins/ml/public/application/components/ml_embedded_map/_ml_embedded_map.scss
@@ -1,4 +1,4 @@
-.dataVisualizerEmbeddedMapContent {
+.mlEmbeddedMapContent {
   width: 100%;
   height: 100%;
   display: flex;
diff --git a/x-pack/plugins/ml/public/application/components/ml_embedded_map/ml_embedded_map.tsx b/x-pack/plugins/ml/public/application/components/ml_embedded_map/ml_embedded_map.tsx
@@ -147,8 +147,8 @@ export function MlEmbeddedMapComponent({
 
   return (
     <div
-      data-test-subj="dataVisualizerEmbeddedMapContent"
-      className="dataVisualizerEmbeddedMapContent"
+      data-test-subj="mlEmbeddedMapContent"
+      className="mlEmbeddedMapContent"
       ref={embeddableRoot}
     />
   );
diff --git a/x-pack/plugins/ml/public/application/datavisualizer/datavisualizer_selector.tsx b/x-pack/plugins/ml/public/application/datavisualizer/datavisualizer_selector.tsx
@@ -138,15 +138,15 @@ export const DatavisualizerSelector: FC = () => {
                   <EuiButton
                     target="_self"
                     onClick={() => navigateToPath('/filedatavisualizer')}
-                    data-test-subj="dataVisualizerUploadFileButton"
+                    data-test-subj="mlDataVisualizerUploadFileButton"
                   >
                     <FormattedMessage
                       id="xpack.ml.datavisualizer.selector.uploadFileButtonLabel"
                       defaultMessage="Select file"
                     />
                   </EuiButton>
                 }
-                data-test-subj="dataVisualizerCardImportData"
+                data-test-subj="mlDataVisualizerCardImportData"
               />
             </EuiFlexItem>
             <EuiFlexItem>
@@ -168,15 +168,15 @@ export const DatavisualizerSelector: FC = () => {
                   <EuiButton
                     target="_self"
                     onClick={() => navigateToPath('/datavisualizer_index_select')}
-                    data-test-subj="dataVisualizerSelectIndexButton"
+                    data-test-subj="mlDataVisualizerSelectIndexButton"
                   >
                     <FormattedMessage
                       id="xpack.ml.datavisualizer.selector.selectIndexButtonLabel"
                       defaultMessage="Select index pattern"
                     />
                   </EuiButton>
                 }
-                data-test-subj="dataVisualizerCardIndexData"
+                data-test-subj="mlDataVisualizerCardIndexData"
               />
             </EuiFlexItem>
           </EuiFlexGroup>
@@ -198,15 +198,15 @@ export const DatavisualizerSelector: FC = () => {
                       <EuiButton
                         target="_blank"
                         href={`${basePath.get()}/app/management/stack/license_management/home`}
-                        data-test-subj="dataVisualizerStartTrialButton"
+                        data-test-subj="mlDataVisualizerStartTrialButton"
                       >
                         <FormattedMessage
                           id="xpack.ml.datavisualizer.selector.startTrialButtonLabel"
                           defaultMessage="Start trial"
                         />
                       </EuiButton>
                     }
-                    data-test-subj="dataVisualizerCardStartTrial"
+                    data-test-subj="mlDataVisualizerCardStartTrial"
                   />
                 </EuiFlexItem>
               </EuiFlexGroup>
diff --git a/x-pack/test/functional/services/ml/data_visualizer.ts b/x-pack/test/functional/services/ml/data_visualizer.ts
@@ -14,19 +14,19 @@ export function MachineLearningDataVisualizerProvider({ getService }: FtrProvide
 
   return {
     async assertDataVisualizerImportDataCardExists() {
-      await testSubjects.existOrFail('dataVisualizerCardImportData');
+      await testSubjects.existOrFail('mlDataVisualizerCardImportData');
     },
 
     async assertDataVisualizerIndexDataCardExists() {
-      await testSubjects.existOrFail('dataVisualizerCardIndexData');
+      await testSubjects.existOrFail('mlDataVisualizerCardIndexData');
     },
 
     async assertDataVisualizerStartTrialCardExists() {
-      await testSubjects.existOrFail('dataVisualizerCardStartTrial');
+      await testSubjects.existOrFail('mlDataVisualizerCardStartTrial');
     },
 
     async assertSelectIndexButtonEnabled(expectedValue: boolean) {
-      const isEnabled = await testSubjects.isEnabled('dataVisualizerSelectIndexButton');
+      const isEnabled = await testSubjects.isEnabled('mlDataVisualizerSelectIndexButton');
       expect(isEnabled).to.eql(
         expectedValue,
         `Expected "select index" button to be '${expectedValue ? 'enabled' : 'disabled'}' (got '${
@@ -36,7 +36,7 @@ export function MachineLearningDataVisualizerProvider({ getService }: FtrProvide
     },
 
     async assertUploadFileButtonEnabled(expectedValue: boolean) {
-      const isEnabled = await testSubjects.isEnabled('dataVisualizerUploadFileButton');
+      const isEnabled = await testSubjects.isEnabled('mlDataVisualizerUploadFileButton');
       expect(isEnabled).to.eql(
         expectedValue,
         `Expected "upload file" button to be '${expectedValue ? 'enabled' : 'disabled'}' (got '${
@@ -46,7 +46,7 @@ export function MachineLearningDataVisualizerProvider({ getService }: FtrProvide
     },
 
     async assertStartTrialButtonEnabled(expectedValue: boolean) {
-      const isEnabled = await testSubjects.isEnabled('dataVisualizerStartTrialButton');
+      const isEnabled = await testSubjects.isEnabled('mlDataVisualizerStartTrialButton');
       expect(isEnabled).to.eql(
         expectedValue,
         `Expected "start trial" button to be '${expectedValue ? 'enabled' : 'disabled'}' (got '${
@@ -56,12 +56,12 @@ export function MachineLearningDataVisualizerProvider({ getService }: FtrProvide
     },
 
     async navigateToIndexPatternSelection() {
-      await testSubjects.click('dataVisualizerSelectIndexButton');
+      await testSubjects.click('mlDataVisualizerSelectIndexButton');
       await testSubjects.existOrFail('mlPageSourceSelection');
     },
 
     async navigateToFileUpload() {
-      await testSubjects.click('dataVisualizerUploadFileButton');
+      await testSubjects.click('mlDataVisualizerUploadFileButton');
       await testSubjects.existOrFail('dataVisualizerPageFileUpload');
     },
   };

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-.dataVisualizerEmbeddedMapContent {`
	`1`	`+.mlEmbeddedMapContent {`
`2`	`2`	`width: 100%;`
`3`	`3`	`height: 100%;`
`4`	`4`	`display: flex;`