Skip to content

Commit 200f874

Browse files
Merge branch 'master' into ml-move-index-data-visualizer
2 parents 4eb627e + 827442b commit 200f874

File tree

453 files changed

+17589
-10712
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

453 files changed

+17589
-10712
lines changed

.github/CODEOWNERS

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
# Client Side Monitoring / Uptime (lives in APM directories but owned by Uptime)
9090
/x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm @elastic/uptime
9191
/x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature @elastic/uptime
92-
/x-pack/plugins/apm/public/application/csmApp.tsx @elastic/uptime
92+
/x-pack/plugins/apm/public/application/uxApp.tsx @elastic/uptime
9393
/x-pack/plugins/apm/public/components/app/RumDashboard @elastic/uptime
9494
/x-pack/plugins/apm/server/lib/rum_client @elastic/uptime
9595
/x-pack/plugins/apm/server/routes/rum_client.ts @elastic/uptime
@@ -128,7 +128,7 @@
128128
/x-pack/test/functional_basic/apps/ml/ @elastic/ml-ui
129129
/x-pack/test/functional_with_es_ssl/apps/ml/ @elastic/ml-ui
130130

131-
# ML team owns and maintains the transform plugin despite it living in the Elasticsearch management section.
131+
# ML team owns and maintains the transform plugin despite it living in the Data management section.
132132
/x-pack/plugins/transform/ @elastic/ml-ui
133133
/x-pack/test/accessibility/apps/transform.ts @elastic/ml-ui
134134
/x-pack/test/api_integration/apis/transform/ @elastic/ml-ui
@@ -305,29 +305,29 @@
305305
/x-pack/plugins/enterprise_search/server/collectors/workplace_search/ @elastic/workplace-search-frontend
306306
/x-pack/plugins/enterprise_search/server/saved_objects/workplace_search/ @elastic/workplace-search-frontend
307307

308-
# Elasticsearch UI
309-
/src/plugins/dev_tools/ @elastic/es-ui
310-
/src/plugins/console/ @elastic/es-ui
311-
/src/plugins/es_ui_shared/ @elastic/es-ui
312-
/x-pack/plugins/cross_cluster_replication/ @elastic/es-ui
313-
/x-pack/plugins/index_lifecycle_management/ @elastic/es-ui
314-
/x-pack/plugins/console_extensions/ @elastic/es-ui
315-
/x-pack/plugins/grokdebugger/ @elastic/es-ui
316-
/x-pack/plugins/index_management/ @elastic/es-ui
317-
/x-pack/plugins/license_api_guard/ @elastic/es-ui
318-
/x-pack/plugins/license_management/ @elastic/es-ui
319-
/x-pack/plugins/painless_lab/ @elastic/es-ui
320-
/x-pack/plugins/remote_clusters/ @elastic/es-ui
321-
/x-pack/plugins/rollup/ @elastic/es-ui
322-
/x-pack/plugins/searchprofiler/ @elastic/es-ui
323-
/x-pack/plugins/snapshot_restore/ @elastic/es-ui
324-
/x-pack/plugins/upgrade_assistant/ @elastic/es-ui
325-
/x-pack/plugins/watcher/ @elastic/es-ui
326-
/x-pack/plugins/ingest_pipelines/ @elastic/es-ui
327-
/packages/kbn-ace/ @elastic/es-ui
328-
/packages/kbn-monaco/ @elastic/es-ui
329-
#CC# /x-pack/plugins/console_extensions/ @elastic/es-ui
330-
#CC# /x-pack/plugins/cross_cluster_replication/ @elastic/es-ui
308+
# Stack Management
309+
/src/plugins/dev_tools/ @elastic/kibana-stack-management
310+
/src/plugins/console/ @elastic/kibana-stack-management
311+
/src/plugins/es_ui_shared/ @elastic/kibana-stack-management
312+
/x-pack/plugins/cross_cluster_replication/ @elastic/kibana-stack-management
313+
/x-pack/plugins/index_lifecycle_management/ @elastic/kibana-stack-management
314+
/x-pack/plugins/console_extensions/ @elastic/kibana-stack-management
315+
/x-pack/plugins/grokdebugger/ @elastic/kibana-stack-management
316+
/x-pack/plugins/index_management/ @elastic/kibana-stack-management
317+
/x-pack/plugins/license_api_guard/ @elastic/kibana-stack-management
318+
/x-pack/plugins/license_management/ @elastic/kibana-stack-management
319+
/x-pack/plugins/painless_lab/ @elastic/kibana-stack-management
320+
/x-pack/plugins/remote_clusters/ @elastic/kibana-stack-management
321+
/x-pack/plugins/rollup/ @elastic/kibana-stack-management
322+
/x-pack/plugins/searchprofiler/ @elastic/kibana-stack-management
323+
/x-pack/plugins/snapshot_restore/ @elastic/kibana-stack-management
324+
/x-pack/plugins/upgrade_assistant/ @elastic/kibana-stack-management
325+
/x-pack/plugins/watcher/ @elastic/kibana-stack-management
326+
/x-pack/plugins/ingest_pipelines/ @elastic/kibana-stack-management
327+
/packages/kbn-ace/ @elastic/kibana-stack-management
328+
/packages/kbn-monaco/ @elastic/kibana-stack-management
329+
#CC# /x-pack/plugins/console_extensions/ @elastic/kibana-stack-management
330+
#CC# /x-pack/plugins/cross_cluster_replication/ @elastic/kibana-stack-management
331331

332332
# Security Solution
333333
/x-pack/test/endpoint_api_integration_no_ingest/ @elastic/security-solution

WORKSPACE.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
1010
# Fetch Node.js rules
1111
http_archive(
1212
name = "build_bazel_rules_nodejs",
13-
sha256 = "10f534e1c80f795cffe1f2822becd4897754d18564612510c59b3c73544ae7c6",
14-
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/3.5.0/rules_nodejs-3.5.0.tar.gz"],
13+
sha256 = "4a5d654a4ccd4a4c24eca5d319d85a88a650edf119601550c95bf400c8cc897e",
14+
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/3.5.1/rules_nodejs-3.5.1.tar.gz"],
1515
)
1616

1717
# Now that we have the rules let's import from them to complete the work
1818
load("@build_bazel_rules_nodejs//:index.bzl", "check_rules_nodejs_version", "node_repositories", "yarn_install")
1919

2020
# Assure we have at least a given rules_nodejs version
21-
check_rules_nodejs_version(minimum_version_string = "3.5.0")
21+
check_rules_nodejs_version(minimum_version_string = "3.5.1")
2222

2323
# Setup the Node.js toolchain for the architectures we want to support
2424
#

dev_docs/tutorials/expressions.mdx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,24 @@ tags: ['kibana', 'onboarding', 'dev', 'architecture']
99

1010
## Expressions service
1111

12-
Expression service exposes a registry of reusable functions primary used for fetching and transposing data and a registry of renderer functions that can render data into a DOM element.
13-
Adding functions is easy and so is reusing them. An expression is a chain of functions with provided arguments, which given a single input translates to a single output.
12+
Expression service exposes a registry of reusable functions primary used for fetching and transposing data and a registry of renderer functions that can render data into a DOM element.
13+
Adding functions is easy and so is reusing them. An expression is a chain of functions with provided arguments, which given a single input translates to a single output.
1414
Each expression is representable by a human friendly string which a user can type.
1515

1616
### creating expressions
1717

1818
Here is a very simple expression string:
1919

20-
essql 'select column1, column2 from myindex' | mapColumn name=column3 fn='{ column1 + 3 }' | table
21-
20+
```
21+
essql 'select column1, column2 from myindex' | mapColumn name=column3 fn='{ column1 + 3 }' | table
22+
```
2223

2324
It consists of 3 functions:
2425

2526
- essql which runs given sql query against elasticsearch and returns the results
2627
- `mapColumn`, which computes a new column from existing ones;
2728
- `table`, which prepares the data for rendering in a tabular format.
28-
29+
2930
The same expression could also be constructed in the code:
3031

3132
```ts
@@ -61,7 +62,7 @@ In addition, on the browser side, there are two additional ways to run expressio
6162
6263
#### React expression renderer component
6364
64-
This is the easiest way to get expressions rendered inside your application.
65+
This is the easiest way to get expressions rendered inside your application.
6566
6667
```ts
6768
<ReactExpressionRenderer expression={expression} />

docs/developer/getting-started/monorepo-packages.asciidoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ yarn kbn watch-bazel
8585
- @kbn/logging
8686
- @kbn/mapbox-gl
8787
- @kbn/monaco
88+
- @kbn/rule-data-utils
8889
- @kbn/securitysolution-es-utils
8990
- @kbn/securitysolution-io-ts-alerting-types
9091
- @kbn/securitysolution-io-ts-list-types

docs/maps/index.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ Create beautiful maps from your geographical data. With **Maps**, you can:
2424
<img
2525
style="width: 100%; margin: auto; display: block;"
2626
class="vidyard-player-embed"
27-
src="https://play.vidyard.com/BYzRDtH4u7RSD8wKhuEW1b.jpg"
28-
data-uuid="BYzRDtH4u7RSD8wKhuEW1b"
27+
src="https://play.vidyard.com/mBuWenQ2uSLY9YjEkPtzJC.jpg"
28+
data-uuid="mBuWenQ2uSLY9YjEkPtzJC"
2929
data-v="4"
3030
data-type="inline"
3131
/>

docs/user/dashboard/lens.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ src="https://play.vidyard.com/embed/v4.js"></script>
1010
<img
1111
style="width: 100%; margin: auto; display: block;"
1212
class="vidyard-player-embed"
13-
src="https://play.vidyard.com/G6RNjq6U9odYRCYUxY2vfq.jpg"
14-
data-uuid="G6RNjq6U9odYRCYUxY2vfq"
13+
src="https://play.vidyard.com/vVJ69WCgUwGNJSDqjPZbaV.jpg"
14+
data-uuid="vVJ69WCgUwGNJSDqjPZbaV"
1515
data-v="4"
1616
data-type="inline"
1717
/>

docs/user/introduction.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ which features.
2626
<img
2727
style="width: 100%; margin: auto; display: block;"
2828
class="vidyard-player-embed"
29-
src="https://play.vidyard.com/jW5wP2dmegbs5ThRZ451Gj.jpg"
30-
data-uuid="jW5wP2dmegbs5ThRZ451Gj"
29+
src="https://play.vidyard.com/iyqMwJcvi8r4YfjeoPMjyH.jpg"
30+
data-uuid="iyqMwJcvi8r4YfjeoPMjyH"
3131
data-v="4"
3232
data-type="inline"
3333
/>

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@
138138
"@kbn/legacy-logging": "link:bazel-bin/packages/kbn-legacy-logging",
139139
"@kbn/logging": "link:bazel-bin/packages/kbn-logging",
140140
"@kbn/monaco": "link:bazel-bin/packages/kbn-monaco",
141-
"@kbn/rule-data-utils": "link:packages/kbn-rule-data-utils",
141+
"@kbn/rule-data-utils": "link:bazel-bin/packages/kbn-rule-data-utils",
142142
"@kbn/securitysolution-list-constants": "link:bazel-bin/packages/kbn-securitysolution-list-constants",
143143
"@kbn/securitysolution-es-utils": "link:bazel-bin/packages/kbn-securitysolution-es-utils",
144144
"@kbn/securitysolution-io-ts-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-types",
@@ -441,7 +441,7 @@
441441
"@babel/traverse": "^7.12.12",
442442
"@babel/types": "^7.12.12",
443443
"@bazel/ibazel": "^0.15.10",
444-
"@bazel/typescript": "^3.5.0",
444+
"@bazel/typescript": "^3.5.1",
445445
"@cypress/snapshot": "^2.1.7",
446446
"@cypress/webpack-preprocessor": "^5.6.0",
447447
"@elastic/apm-rum": "^5.6.1",

packages/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ filegroup(
2828
"//packages/kbn-mapbox-gl:build",
2929
"//packages/kbn-monaco:build",
3030
"//packages/kbn-plugin-generator:build",
31+
"//packages/kbn-rule-data-utils:build",
3132
"//packages/kbn-securitysolution-list-constants:build",
3233
"//packages/kbn-securitysolution-io-ts-types:build",
3334
"//packages/kbn-securitysolution-io-ts-alerting-types:build",

packages/kbn-apm-utils/src/index.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ export interface SpanOptions {
1616
labels?: Record<string, string>;
1717
}
1818

19+
type Span = Exclude<typeof agent.currentSpan, undefined | null>;
20+
1921
export function parseSpanOptions(optionsOrName: SpanOptions | string) {
2022
const options = typeof optionsOrName === 'string' ? { name: optionsOrName } : optionsOrName;
2123

@@ -30,7 +32,7 @@ const runInNewContext = <T extends (...args: any[]) => any>(cb: T): ReturnType<T
3032

3133
export async function withSpan<T>(
3234
optionsOrName: SpanOptions | string,
33-
cb: () => Promise<T>
35+
cb: (span?: Span) => Promise<T>
3436
): Promise<T> {
3537
const options = parseSpanOptions(optionsOrName);
3638

@@ -71,13 +73,17 @@ export async function withSpan<T>(
7173
span.addLabels(labels);
7274
}
7375

74-
return cb()
76+
return cb(span)
7577
.then((res) => {
76-
span.outcome = 'success';
78+
if (!span.outcome || span.outcome === 'unknown') {
79+
span.outcome = 'success';
80+
}
7781
return res;
7882
})
7983
.catch((err) => {
80-
span.outcome = 'failure';
84+
if (!span.outcome || span.outcome === 'unknown') {
85+
span.outcome = 'failure';
86+
}
8187
throw err;
8288
})
8389
.finally(() => {

0 commit comments

Comments
 (0)