fix errors in transform plugin

elastic · Jun 4, 2021 · 4d562e5 · 4d562e5
1 parent 4e5e3d4
commit 4d562e5
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/x-pack/plugins/transform/common/api_schemas/type_guards.ts b/x-pack/plugins/transform/common/api_schemas/type_guards.ts
@@ -74,7 +74,7 @@ export const isEsSearchResponseWithAggregations = (
 
 export const isMultiBucketAggregate = <TBucket = unknown>(
   arg: unknown
-): arg is estypes.MultiBucketAggregate<TBucket> => {
+): arg is estypes.AggregationsMultiBucketAggregate<TBucket> => {
   return isPopulatedObject(arg, ['buckets']);
 };
 

diff --git a/x-pack/plugins/transform/public/app/hooks/use_index_data.ts b/x-pack/plugins/transform/public/app/hooks/use_index_data.ts
@@ -206,7 +206,7 @@ export const useIndexData = (
     setRowCount(typeof resp.hits.total === 'number' ? resp.hits.total : resp.hits.total.value);
     setRowCountRelation(
       typeof resp.hits.total === 'number'
-        ? ('eq' as estypes.TotalHitsRelation)
+        ? ('eq' as estypes.SearchTotalHitsRelation)
         : resp.hits.total.relation
     );
     setTableItems(docs);

diff --git a/...create_transform/components/step_define/common/filter_agg/components/filter_term_form.tsx b/...create_transform/components/step_define/common/filter_agg/components/filter_term_form.tsx
@@ -69,7 +69,9 @@ export const FilterTermForm: FilterAggConfigTerm['aggTypeConfig']['FilterAggForm
       if (
         !(
           isEsSearchResponseWithAggregations(response) &&
-          isMultiBucketAggregate<estypes.KeyedBucketKeys>(response.aggregations.field_values)
+          isMultiBucketAggregate<estypes.AggregationsKeyedBucketKeys>(
+            response.aggregations.field_values
+          )
         )
       ) {
         toastNotifications.addWarning(

diff --git a/x-pack/plugins/transform/server/routes/api/field_histograms.ts b/x-pack/plugins/transform/server/routes/api/field_histograms.ts
@@ -41,7 +41,6 @@ export function registerFieldHistogramsRoutes({ router, license }: RouteDependen
             query,
             fields,
             samplerShardSize,
-            // @ts-expect-error script is not compatible with StoredScript from @elastic/elasticsearch: string is not supported
             runtimeMappings
           );
 

diff --git a/x-pack/plugins/transform/server/routes/api/transforms.ts b/x-pack/plugins/transform/server/routes/api/transforms.ts
@@ -6,6 +6,7 @@
  */
 
 import { schema } from '@kbn/config-schema';
+import type { estypes } from '@elastic/elasticsearch';
 
 import {
   ElasticsearchClient,
@@ -570,7 +571,10 @@ const previewTransformHandler: RequestHandler<
         return acc;
       }, {} as Record<string, { type: string }>);
 
-      body.generated_dest_index.mappings.properties = fields;
+      body.generated_dest_index.mappings!.properties = fields as Record<
+        string,
+        estypes.MappingProperty
+      >;
     }
     return res.ok({ body });
   } catch (e) {