[Profiling] Remove setting for Elasticsearch profiling plugin (#157822)

## Summary This PR removes the advanced setting that toggles access to the Elasticsearch profiling plugin. The setting is no longer needed since it was deprecated by #155955.
elastic · May 17, 2023 · 0b5c7c2 · 0b5c7c2
1 parent 93b15b1
commit 0b5c7c2
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 171 deletions.
diff --git a/api_docs/observability.devdocs.json b/api_docs/observability.devdocs.json
@@ -12065,124 +12065,6 @@
               }
             ]
           },
-          {
-            "parentPluginId": "observability",
-            "id": "def-server.uiSettings.profilingElasticsearchPlugin",
-            "type": "Object",
-            "tags": [],
-            "label": "[profilingElasticsearchPlugin]",
-            "description": [],
-            "path": "x-pack/plugins/observability/server/ui_settings.ts",
-            "deprecated": false,
-            "trackAdoption": false,
-            "children": [
-              {
-                "parentPluginId": "observability",
-                "id": "def-server.uiSettings.profilingElasticsearchPlugin.category",
-                "type": "Array",
-                "tags": [],
-                "label": "category",
-                "description": [],
-                "signature": [
-                  "string[]"
-                ],
-                "path": "x-pack/plugins/observability/server/ui_settings.ts",
-                "deprecated": false,
-                "trackAdoption": false
-              },
-              {
-                "parentPluginId": "observability",
-                "id": "def-server.uiSettings.profilingElasticsearchPlugin.name",
-                "type": "Any",
-                "tags": [],
-                "label": "name",
-                "description": [],
-                "signature": [
-                  "any"
-                ],
-                "path": "x-pack/plugins/observability/server/ui_settings.ts",
-                "deprecated": false,
-                "trackAdoption": false
-              },
-              {
-                "parentPluginId": "observability",
-                "id": "def-server.uiSettings.profilingElasticsearchPlugin.description",
-                "type": "Any",
-                "tags": [],
-                "label": "description",
-                "description": [],
-                "signature": [
-                  "any"
-                ],
-                "path": "x-pack/plugins/observability/server/ui_settings.ts",
-                "deprecated": false,
-                "trackAdoption": false
-              },
-              {
-                "parentPluginId": "observability",
-                "id": "def-server.uiSettings.profilingElasticsearchPlugin.schema",
-                "type": "Object",
-                "tags": [],
-                "label": "schema",
-                "description": [],
-                "signature": [
-                  {
-                    "pluginId": "@kbn/config-schema",
-                    "scope": "common",
-                    "docId": "kibKbnConfigSchemaPluginApi",
-                    "section": "def-common.Type",
-                    "text": "Type"
-                  },
-                  "<boolean>"
-                ],
-                "path": "x-pack/plugins/observability/server/ui_settings.ts",
-                "deprecated": false,
-                "trackAdoption": false
-              },
-              {
-                "parentPluginId": "observability",
-                "id": "def-server.uiSettings.profilingElasticsearchPlugin.value",
-                "type": "boolean",
-                "tags": [],
-                "label": "value",
-                "description": [],
-                "signature": [
-                  "true"
-                ],
-                "path": "x-pack/plugins/observability/server/ui_settings.ts",
-                "deprecated": false,
-                "trackAdoption": false
-              },
-              {
-                "parentPluginId": "observability",
-                "id": "def-server.uiSettings.profilingElasticsearchPlugin.requiresPageReload",
-                "type": "boolean",
-                "tags": [],
-                "label": "requiresPageReload",
-                "description": [],
-                "signature": [
-                  "true"
-                ],
-                "path": "x-pack/plugins/observability/server/ui_settings.ts",
-                "deprecated": false,
-                "trackAdoption": false
-              },
-              {
-                "parentPluginId": "observability",
-                "id": "def-server.uiSettings.profilingElasticsearchPlugin.type",
-                "type": "string",
-                "tags": [],
-                "label": "type",
-                "description": [],
-                "signature": [
-                  "\"boolean\""
-                ],
-                "path": "x-pack/plugins/observability/server/ui_settings.ts",
-                "deprecated": false,
-                "trackAdoption": false
-              }
-            ]
-          },
           {
             "parentPluginId": "observability",
             "id": "def-server.uiSettings.syntheticsThrottlingEnabled",
@@ -13185,21 +13067,6 @@
         "trackAdoption": false,
         "initialIsOpen": false
       },
-      {
-        "parentPluginId": "observability",
-        "id": "def-common.profilingElasticsearchPlugin",
-        "type": "string",
-        "tags": [],
-        "label": "profilingElasticsearchPlugin",
-        "description": [],
-        "signature": [
-          "\"observability:profilingElasticsearchPlugin\""
-        ],
-        "path": "x-pack/plugins/observability/common/ui_settings_keys.ts",
-        "deprecated": false,
-        "trackAdoption": false,
-        "initialIsOpen": false
-      },
       {
         "parentPluginId": "observability",
         "id": "def-common.ruleDetailsLocatorID",
@@ -13536,4 +13403,4 @@
     ],
     "objects": []
   }
-}
+}
diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@@ -450,10 +450,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
     type: 'integer',
     _meta: { description: 'Non-default value of setting.' },
   },
-  'observability:profilingElasticsearchPlugin': {
-    type: 'boolean',
-    _meta: { description: 'Non-default value of setting.' },
-  },
   'banners:placement': {
     type: 'keyword',
     _meta: { description: 'Non-default value of setting.' },

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
@@ -46,7 +46,6 @@ export interface UsageStats {
   'observability:apmAWSLambdaRequestCostPerMillion': number;
   'observability:enableInfrastructureHostsView': boolean;
   'observability:apmAgentExplorerView': boolean;
-  'observability:profilingElasticsearchPlugin': boolean;
   'visualize:enableLabs': boolean;
   'visualization:heatmap:maxBuckets': number;
   'visualization:colorMapping': string;

diff --git a/src/plugins/telemetry/schema/oss_plugins.json b/src/plugins/telemetry/schema/oss_plugins.json
@@ -9196,12 +9196,6 @@
             "description": "Non-default value of setting."
           }
         },
-        "observability:profilingElasticsearchPlugin": {
-          "type": "boolean",
-          "_meta": {
-            "description": "Non-default value of setting."
-          }
-        },
         "banners:placement": {
           "type": "keyword",
           "_meta": {

diff --git a/x-pack/plugins/observability/common/index.ts b/x-pack/plugins/observability/common/index.ts
@@ -34,7 +34,6 @@ export {
   apmEnableServiceMetrics,
   apmEnableContinuousRollups,
   enableCriticalPath,
-  profilingElasticsearchPlugin,
   syntheticsThrottlingEnabled,
 } from './ui_settings_keys';
 

diff --git a/x-pack/plugins/observability/common/ui_settings_keys.ts b/x-pack/plugins/observability/common/ui_settings_keys.ts
@@ -24,5 +24,4 @@ export const apmAWSLambdaRequestCostPerMillion = 'observability:apmAWSLambdaRequ
 export const enableCriticalPath = 'observability:apmEnableCriticalPath';
 export const apmEnableServiceMetrics = 'observability:apmEnableServiceMetrics';
 export const apmEnableContinuousRollups = 'observability:apmEnableContinuousRollups';
-export const profilingElasticsearchPlugin = 'observability:profilingElasticsearchPlugin';
 export const syntheticsThrottlingEnabled = 'observability:syntheticsThrottlingEnabled';
diff --git a/x-pack/plugins/observability/server/ui_settings.ts b/x-pack/plugins/observability/server/ui_settings.ts
@@ -27,7 +27,6 @@ import {
   apmEnableContinuousRollups,
   enableCriticalPath,
   enableInfrastructureHostsView,
-  profilingElasticsearchPlugin,
   syntheticsThrottlingEnabled,
 } from '../common/ui_settings_keys';
 
@@ -338,23 +337,6 @@ export const uiSettings: Record<string, UiSettings> = {
     type: 'boolean',
     showInLabs: true,
   },
-  [profilingElasticsearchPlugin]: {
-    category: [observabilityFeatureId],
-    name: i18n.translate('xpack.observability.profilingElasticsearchPlugin', {
-      defaultMessage: 'Use Elasticsearch profiler plugin',
-    }),
-    description: i18n.translate('xpack.observability.profilingElasticsearchPluginDescription', {
-      defaultMessage:
-        '{technicalPreviewLabel} Whether to load stacktraces using Elasticsearch profiler plugin.',
-      values: {
-        technicalPreviewLabel: `<em>[${technicalPreviewLabel}]</em>`,
-      },
-    }),
-    schema: schema.boolean(),
-    value: true,
-    requiresPageReload: true,
-    type: 'boolean',
-  },
   [syntheticsThrottlingEnabled]: {
     category: [observabilityFeatureId],
     name: i18n.translate('xpack.observability.syntheticsThrottlingEnabledExperimentName', {

diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json
@@ -25081,7 +25081,6 @@
     "xpack.observability.fieldValueSelection.placeholder": "Filtrer {label}",
     "xpack.observability.fieldValueSelection.placeholder.search": "Rechercher {label}",
     "xpack.observability.filterButton.label": "développe le groupe de filtres pour le filtre {label}",
-    "xpack.observability.profilingElasticsearchPluginDescription": "{technicalPreviewLabel} Si les traces d'appel doivent être chargées à l'aide du plug-in de profilage Elasticsearch.",
     "xpack.observability.ruleDetails.executionLogError": "Impossible de charger le log d'exécution de la règle. Raison : {message}",
     "xpack.observability.ruleDetails.ruleLoadError": "Impossible de charger la règle. Raison : {message}",
     "xpack.observability.rules.deleteSelectedIdsConfirmModal.deleteButtonLabel": "Supprimer {numIdsToDelete, plural, one {{singleTitle}} other {# {multipleTitle}}} ",
@@ -25287,7 +25286,6 @@
     "xpack.observability.page_header.addUptimeDataLink.label": "Accédez à un tutoriel sur l'ajout de données Uptime",
     "xpack.observability.page_header.addUXDataLink.label": "Accédez à un tutoriel sur l'ajout de données APM d'expérience utilisateur.",
     "xpack.observability.pageLayout.sideNavTitle": "Observabilité",
-    "xpack.observability.profilingElasticsearchPlugin": "Utiliser le plug-in de profileur Elasticsearch",
     "xpack.observability.resources.documentation": "Documentation",
     "xpack.observability.resources.forum": "Forum de discussion",
     "xpack.observability.resources.quick_start": "Vidéos de démarrage rapide",

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -25066,7 +25066,6 @@
     "xpack.observability.fieldValueSelection.placeholder": "フィルター{label}",
     "xpack.observability.fieldValueSelection.placeholder.search": "{label}を検索",
     "xpack.observability.filterButton.label": "{label}フィルターのフィルターグループを展開",
-    "xpack.observability.profilingElasticsearchPluginDescription": "{technicalPreviewLabel} Elasticsearchプロファイラープラグインを使用してスタックトレースを読み込むかどうか。",
     "xpack.observability.ruleDetails.executionLogError": "ルール実行ログを読み込めません。理由：{message}",
     "xpack.observability.ruleDetails.ruleLoadError": "ルールを読み込めません。理由：{message}",
     "xpack.observability.slo.alerting.burnRate.reason": "過去{longWindowDuration}のバーンレートは{longWindowBurnRate}で、過去{shortWindowDuration}のバーンレートは{shortWindowBurnRate}です。両期間とも{burnRateThreshold}を超えたらアラート",
@@ -25268,7 +25267,6 @@
     "xpack.observability.page_header.addUptimeDataLink.label": "アップタイムデータの追加に関するチュートリアルに移動",
     "xpack.observability.page_header.addUXDataLink.label": "ユーザーエクスペリエンスAPMデータの追加に関するチュートリアルに移動",
     "xpack.observability.pageLayout.sideNavTitle": "Observability",
-    "xpack.observability.profilingElasticsearchPlugin": "Elasticsearchプロファイラープラグインを使用",
     "xpack.observability.resources.documentation": "ドキュメント",
     "xpack.observability.resources.forum": "ディスカッションフォーラム",
     "xpack.observability.resources.quick_start": "クイックスタートビデオ",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -25080,7 +25080,6 @@
     "xpack.observability.fieldValueSelection.placeholder": "筛选 {label}",
     "xpack.observability.fieldValueSelection.placeholder.search": "搜索 {label}",
     "xpack.observability.filterButton.label": "展开筛选 {label} 的筛选组",
-    "xpack.observability.profilingElasticsearchPluginDescription": "{technicalPreviewLabel} 是否使用 Elasticsearch 分析器插件加载堆栈跟踪。",
     "xpack.observability.ruleDetails.executionLogError": "无法加载规则执行日志。原因：{message}",
     "xpack.observability.ruleDetails.ruleLoadError": "无法加载规则。原因：{message}",
     "xpack.observability.rules.deleteSelectedIdsConfirmModal.deleteButtonLabel": "删除{numIdsToDelete, plural, one {{singleTitle}} other {# 个{multipleTitle}}}",
@@ -25286,7 +25285,6 @@
     "xpack.observability.page_header.addUptimeDataLink.label": "导航到有关如何添加 Uptime 数据的教程",
     "xpack.observability.page_header.addUXDataLink.label": "导航到有关如何添加用户体验 APM 数据的教程",
     "xpack.observability.pageLayout.sideNavTitle": "Observability",
-    "xpack.observability.profilingElasticsearchPlugin": "使用 Elasticsearch 分析器插件",
     "xpack.observability.resources.documentation": "文档",
     "xpack.observability.resources.forum": "讨论论坛",
     "xpack.observability.resources.quick_start": "快速入门视频",