Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Commit

Permalink
[start] send extra args to the kibana process
Browse files Browse the repository at this point in the history
  • Loading branch information
spalger committed Oct 21, 2016
1 parent 4a8ccce commit ce943ca
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 7 deletions.
13 changes: 8 additions & 5 deletions bin/plugin-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@ var program = require('commander');
var pkg = require('../package.json');
var run = require('../lib/run');
var docs = require('../lib/docs');
var enableCollectingUnknownOptions = require('../lib/enable_collecting_unknown_options');

program
.version(pkg.version);

program
.command('start')
.description('Start kibana and have it include this plugin')
.on('--help', docs('start'))
.action(run('start'));
enableCollectingUnknownOptions(
program
.command('start')
.description('Start kibana and have it include this plugin')
.on('--help', docs('start'))
.action(run('start'))
);

program
.command('build')
Expand Down
10 changes: 10 additions & 0 deletions lib/enable_collecting_unknown_options.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@

module.exports = function enableCollectingUnknownOptions(command) {
var origParse = command.parseOptions;
command.allowUnknownOption();
command.parseOptions = function (argv) {
let opts = origParse.call(this, argv);
this.unkownOptions = opts.unknown;
return opts;
};
};
4 changes: 2 additions & 2 deletions tasks/start/start_action.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
module.exports = function (plugin) {
module.exports = function (plugin, command) {
var resolve = require('path').resolve;
var execFileSync = require('child_process').execFileSync;

var kibanaDir = resolve(plugin.root, '../kibana');

var cmd = (process.platform === 'win32') ? 'bin\\kibana.bat' : 'bin/kibana';
var args = ['--dev', '--plugin-path', plugin.root];
var args = ['--dev', '--plugin-path', plugin.root, ...command.unkownOptions];
execFileSync(cmd, args, {
cwd: kibanaDir,
stdio: 'inherit'
Expand Down

0 comments on commit ce943ca

Please sign in to comment.