-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ti_opencti] Add support for IOC expiration #8920
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
/test |
🚀 Benchmarks reportTo see the full report comment with |
e3d535e
to
ebfb734
Compare
…resolve partial navigation issue.
ebfb734
to
0467f90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits only.
packages/ti_opencti/kibana/dashboard/ti_opencti-274cda10-b452-11ee-9ed7-19d912c01624.json
Outdated
Show resolved
Hide resolved
packages/ti_opencti/data_stream/indicator/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
6c6bd7e
to
7aa3fe1
Compare
💚 Build Succeeded
History
|
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Package ti_opencti - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=ti_opencti |
Proposed commit message
Discussion
I'm assuming that
opencti.indicator.valid_from
will not have future values. That means I assume that an indicator will always be valid between the time its created and the time it expires or is revoked, rather than allowing e.g. "this will be valid starting next week".As mentioned in the README, I don't clean up indicators that are never expired or revoked (a.k.a. "orphaned IOCs"), because I think that in the case of OpenCTI this can best be handled upstream or manually.
I started with the
- external: ecs
field definitions in a separate file from the existing ECS extensions and override definitions, but in the end I had to combine them into one file due to what seems to be a bug in Fleet.I needed to raise the stack version in
conditions.kibana.version
from8.9.0
to8.10.1
to avoid this error:Checklist
changelog.yml
file.How to test this PR locally
You can test manually using the OpenCTI public demo instance. Note that the ingest dashboard will show immediate activity but it may take some time before non-revoked indicators are ingested and appear in the latest index.
The files shared between the data stream and the transform are the same:
Related issues
Screenshots
Please see the updated screenshots (1-3) in the integration.