-
Notifications
You must be signed in to change notification settings - Fork 513
[ci] Fix Jenkinsfile to use the json files for pipeline benchmarks reporting #8346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mrodm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fix the paths to get the right files from local or from the artifacts uploaded.
However, since this PR not all the packages are run when a PR is merged into main branch. So, in the latest artifacts generated for a given build there could be missing benchmarks for some packages @marc-gr cc @jsoriano
That could lead to not being able to execute the benchmarks for a given package in a Pull Request, since it's likely that baseline files for that package do not exist.
Would it be an option to run a daily job to create baselines? |
🌐 Coverage report
|
@jsoriano I guess this could be an option, but still it would require some changes. If this daily job is added to the current schedule-daily job, it should be checked how to retrieve the specific artifacts, since there are already a couple of jobs triggered. Another option could be to add/create a new daily job that run tests in all packages, so it can be retrieved the artifacts from those specific builds. In any case, it needs to be investigated how to retrieve the desired artifacts (baselines) from the right path of the bucket. Probably it would need to change the path in the bucket to store the benchmark results to be able to distinguish them. |
Proposed commit message
Now benchmarks results are generated as JSON files, this changes Jenkinsfile to use these instead of the old XML ones.
Checklist
- [ ] I have verified that all data streams collect metrics or logs.- [ ] I have added an entry to my package'schangelog.ymlfile.- [ ] I have verified that Kibana version constraints are current according to guidelines.