Skip to content

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 31, 2023

Proposed commit message

Now benchmarks results are generated as JSON files, this changes Jenkinsfile to use these instead of the old XML ones.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
    - [ ] I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr requested a review from a team as a code owner October 31, 2023 08:17
@marc-gr marc-gr requested a review from mrodm October 31, 2023 08:49
Copy link
Collaborator

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix the paths to get the right files from local or from the artifacts uploaded.

However, since this PR not all the packages are run when a PR is merged into main branch. So, in the latest artifacts generated for a given build there could be missing benchmarks for some packages @marc-gr cc @jsoriano

That could lead to not being able to execute the benchmarks for a given package in a Pull Request, since it's likely that baseline files for that package do not exist.

@jsoriano
Copy link
Member

However, since this PR not all the packages are run when a PR is merged into main branch. So, in the latest artifacts generated for a given build there could be missing benchmarks for some packages @marc-gr cc @jsoriano

That could lead to not being able to execute the benchmarks for a given package in a Pull Request, since it's likely that baseline files for that package do not exist.

Would it be an option to run a daily job to create baselines?

@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-02T12:53:19.203+0000

  • Duration: 124 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 5066
Skipped 9
Total 5075

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (470/470) 💚
Files 96.168% (803/835) 👎 -3.832
Classes 96.168% (803/835) 👎 -3.832
Methods 92.063% (7806/8479) 👎 -5.306
Lines 88.613% (184241/207916) 👎 -6.814
Conditionals 100.0% (0/0) 💚

@mrodm
Copy link
Collaborator

mrodm commented Nov 2, 2023

Would it be an option to run a daily job to create baselines?

@jsoriano I guess this could be an option, but still it would require some changes.

If this daily job is added to the current schedule-daily job, it should be checked how to retrieve the specific artifacts, since there are already a couple of jobs triggered.

Another option could be to add/create a new daily job that run tests in all packages, so it can be retrieved the artifacts from those specific builds.

In any case, it needs to be investigated how to retrieve the desired artifacts (baselines) from the right path of the bucket. Probably it would need to change the path in the bucket to store the benchmark results to be able to distinguish them.

@marc-gr marc-gr merged commit bcc84a8 into elastic:main Nov 3, 2023
@marc-gr marc-gr deleted the fix-benchs-ci branch November 3, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants