Skip to content

Conversation

@kush-elastic
Copy link
Contributor

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Nginx Ingress Controller visualizations to the lens in the current Kibana version 8.6.0 itself.

  • Statistics for Nginx Ingress Controller Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Nginx Ingress] Overview 0 11 11 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.6.0 itself.

Related issues

Before Migration
image

After Migration
image

@kush-elastic kush-elastic added Integration:nginx_ingress_controller Nginx Ingress Controller Logs dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Oct 10, 2023
@kush-elastic kush-elastic self-assigned this Oct 10, 2023
@kush-elastic kush-elastic marked this pull request as ready for review October 10, 2023 07:07
@kush-elastic kush-elastic requested a review from a team as a code owner October 10, 2023 07:07
@elasticmachine
Copy link

elasticmachine commented Oct 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T07:07:06.146+0000

  • Duration: 15 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.313
Classes 100.0% (2/2) 💚 3.313
Methods 92.0% (23/25) 👎 -0.362
Lines 94.461% (324/343) 👍 6.047
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 self-requested a review October 11, 2023 08:55
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit e652ce7 into elastic:main Oct 11, 2023
@elasticmachine
Copy link

Package nginx_ingress_controller - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:nginx_ingress_controller Nginx Ingress Controller Logs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants