[box_events] - Clean-up field definitions #8097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 'external: ecs' where possible. Set 'type: group' instead of 'type: object' on field groups. Remove unnecessary field attributes (like group, footnote). [git-generate] cd packages/box_events go run github.com/andrewkroh/fydler@becb7a7 -fix **/fields/* elastic-package format
I think an explicit type will be better than depending on defaults being injected elsewhere.
andrewkroh
added
enhancement
[git-generate] elastic-package changelog add --link #8097 --type enhancement --next minor --description "Modified the field definitions to reference ECS where possible and remove invalid field attributes."
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
efd6
approved these changes
Oct 4, 2023
[git-generate] go run github.com/andrewkroh/fydler@e90f9031ec48 -fix -a unknownattribute packages/box_events/**/fields/*.yml
|
Package box_events - 2.2.0 containing this change is available at https://epr.elastic.co/search?package=box_events |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Modified the field definitions to reference ECS where possible and remove unnecessary field attributes.
Checklist
changelog.ymlfile.