Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable static test runner #754

Merged
merged 20 commits into from
Mar 2, 2021
Merged

Enable static test runner #754

merged 20 commits into from
Mar 2, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Mar 1, 2021

What does this PR do?

This PR enables static test runner which can validate sample_event.json files.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@mtojek mtojek self-assigned this Mar 1, 2021
@elasticmachine
Copy link

elasticmachine commented Mar 1, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #754 updated

  • Start Time: 2021-03-02T16:09:38.731+0000

  • Duration: 40 min 13 sec

  • Commit: 2cfc1a7

Test stats 🧪

Test Results
Failed 0
Passed 1842
Skipped 3
Total 1845

Trends 🧪

Image of Build Times

Image of Tests

@ycombinator ycombinator mentioned this pull request Mar 1, 2021
Merged
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 1, 2021
@mtojek mtojek requested a review from ycombinator March 2, 2021 11:09
@mtojek mtojek marked this pull request as ready for review March 2, 2021 11:09
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@mtojek
Copy link
Contributor Author

mtojek commented Mar 2, 2021

jenkins run the tests please

1 similar comment
@mtojek
Copy link
Contributor Author

mtojek commented Mar 2, 2021

jenkins run the tests please

ycombinator
ycombinator reviewed Mar 2, 2021
View reviewed changes
packages/aws/manifest.yml
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: aws
title: AWS
version: 0.4.0
version: 0.4.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump up the version?

ycombinator
ycombinator reviewed Mar 2, 2021
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in packages LGTM, except I'm wondering if we want to bump up the versions in the package's manifest.yml files for these changes. They could go out with other changes in the future, no?

@mtojek
Copy link
Contributor Author

mtojek commented Mar 2, 2021

Changes in packages LGTM, except I'm wondering if we want to bump up the versions in the package's manifest.yml files for these changes. They could go out with other changes in the future, no?

I would say that this PR cleans up the package content which is shown to the customer (sample events) and we don't have any publishing timeline for these packages. If you don't mind, I would be for releasing them due to consistency reasons (all sample events are looking the same).

@ycombinator
Copy link
Contributor

I would be for releasing them due to consistency reasons (all sample events are looking the same).

Ah, okay, that makes sense then. ++ to upversioning.

ycombinator
ycombinator approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit 8770467 into elastic:master Mar 2, 2021
@mtojek mtojek mentioned this pull request Mar 3, 2021
Closed
8 tasks
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@mtojek
Enable static test runner (elastic#754)
1c900dc 
* Update dependency on elastic-package

* Adjust AWS integration

* Adjust other integrations

* Adjust zookeeper

* Adjust Redis

* Adjust Kubernetes integration

* Correct Azure integration

* Fix Haproxy

* Fix nats

* Fix IIS

* Fix

* Fix Kafka

* Fix mongodb

* Fix MySQL

* Fix Postgresql

* Fix Prometheus

* Fix RabbitMQ

* Use latest elastic-package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@mtojek mtojek

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtojek @elasticmachine @ycombinator @andresrc