-
Notifications
You must be signed in to change notification settings - Fork 474
Move RSA packages from package-storage to integrations #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RSA packages from package-storage to integrations #477
Conversation
entrypoint: /bin/bash | ||
command: -c "/stream log --start-signal=SIGHUP --delay=5s --addr elastic-agent:9540 -p=udp /sample_logs/barracuda-spamfirewall-*.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here overriding the entrypoint is necessary to have globs working in the arguments.
I need this because the tests are autogenerated and it's not easy to list all the test files that are going to be there when the template is applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been wanted to have stream
expand the glob too. I just created https://github.com/andrewkroh/stream/issues/8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at one and it LGTM.
entrypoint: /bin/bash | ||
command: -c "/stream log --start-signal=SIGHUP --delay=5s --addr elastic-agent:9540 -p=udp /sample_logs/barracuda-spamfirewall-*.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been wanted to have stream
expand the glob too. I just created https://github.com/andrewkroh/stream/issues/8.
- ${SERVICE_LOGS_DIR}:/var/log | ||
command: /bin/sh -c "cp /sample_logs/* /var/log/" | ||
barracuda-spamfirewall-udp: | ||
image: akroh/stream:v0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a v0.2.0 now. https://github.com/andrewkroh/stream/blob/main/CHANGELOG.md
None of the changes affect log streaming so it doesn't matter if you update.
run tests |
What does this PR do?
Moves the new version of RSA packages into this repository to avoid maintaining two separate repositories for some packages.
Until now only the packages that had non-RSA filesets existed in integrations.
Checklist