Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logo in Elastic Package Registry integration #3880

Merged
merged 4 commits into from
Jul 29, 2022

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jul 28, 2022

What does this PR do?

Add the new Elastic Package Registry logo to be used as icon of the integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • New logo is shown in both integrations UI and in its own description

Related issues

Screenshots

EPR new logo tile view

EPR new logo details view

@mrodm mrodm added enhancement New feature or request Team:Ecosystem Label for the Packages Ecosystem team [elastic/ecosystem] labels Jul 28, 2022
@mrodm mrodm self-assigned this Jul 28, 2022
@mrodm mrodm changed the title Update logo Update logo in Elastic Package Registry integration Jul 28, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-29T07:55:25.661+0000

  • Duration: 15 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 28, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.046
Classes 100.0% (1/1) 💚 3.046
Methods 100.0% (8/8) 💚 10.629
Lines 100.0% (77/77) 💚 9.908
Conditionals 100.0% (0/0) 💚

@mrodm mrodm marked this pull request as ready for review July 29, 2022 07:59
@mrodm mrodm requested a review from a team as a code owner July 29, 2022 07:59
@mtojek
Copy link
Contributor

mtojek commented Jul 29, 2022

Actually, you can also replace the default favicon we're using in EPR :)

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice icon! 🙂

@mrodm mrodm merged commit 43fda6a into elastic:main Jul 29, 2022
@mrodm mrodm deleted the update_epr_logo branch July 29, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Ecosystem Label for the Packages Ecosystem team [elastic/ecosystem]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants