Skip to content

Adjust integrations to pass linting #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Adjust integrations to pass linting #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ go 1.12

require (
github.com/blang/semver v3.5.1+incompatible
github.com/elastic/elastic-package v0.0.0-20200831071658-5f815c01ff57
github.com/elastic/elastic-package v0.0.0-20200909015411-e62cc86d13a3
github.com/elastic/package-registry v0.10.0
github.com/elastic/package-spec/code/go v0.0.0-20200909122231-c8a8684bc46c // indirect
github.com/magefile/mage v1.10.0
github.com/pkg/errors v0.9.1
gopkg.in/yaml.v2 v2.3.0
Expand Down
24 changes: 22 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZmtrrCbhqsmaPHjLKYnJCaQ=
github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8PWV+bWy6jNmig1y/TA+kYO4g3RSRF0IAv0no=
github.com/elastic/elastic-package v0.0.0-20200831071658-5f815c01ff57 h1:8XGJOnBG8JvkcsiQkSqAwIjW4yWaPqCvM/2R8HLVUK4=
github.com/elastic/elastic-package v0.0.0-20200831071658-5f815c01ff57/go.mod h1:7joSVcFOJpURmU/pJAw1AwZ69114jIkHJ+VtQCp3IHY=
github.com/elastic/elastic-package v0.0.0-20200909015411-e62cc86d13a3 h1:iKBF/rlrnd669GDvWl3mPe6OS0RzrtrwQJzmSB4Nb60=
github.com/elastic/elastic-package v0.0.0-20200909015411-e62cc86d13a3/go.mod h1:AksZrN09ZEu0u/haAQA9e039IrSY1ZdGnd14w/Y32n0=
github.com/elastic/go-elasticsearch/v7 v7.9.0 h1:UEau+a1MiiE/F+UrDj60kqIHFWdzU1M2y/YtBU2NC2M=
github.com/elastic/go-elasticsearch/v7 v7.9.0/go.mod h1:OJ4wdbtDNk5g503kvlHLyErCgQwwzmDtaFC4XyOxXA4=
github.com/elastic/go-ucfg v0.8.4-0.20200415140258-1232bd4774a6 h1:Ehbr7du4rSSEypR8zePr0XRbMhO4PJgcHC9f8fDbgAg=
Expand All @@ -52,6 +52,8 @@ github.com/elastic/package-registry v0.10.0 h1:xmXC571rU36qUxMV1lo3VYfwho0hUONL4
github.com/elastic/package-registry v0.10.0/go.mod h1:oQx3Tg9ynuC6APd0o0OHud9kyPX6S6IzdJp/R4Hj1HY=
github.com/elastic/package-spec/code/go v0.0.0-20200826192647-f45b05c887b5 h1:dU/3GrZmkqlSleGIuiDXuDXbc3bn8gTz08niTshFahU=
github.com/elastic/package-spec/code/go v0.0.0-20200826192647-f45b05c887b5/go.mod h1:kiy4Ln4Jm59Y2xD0BVyFmzZvqtdMlA2D9mx0mtAzz2w=
github.com/elastic/package-spec/code/go v0.0.0-20200909122231-c8a8684bc46c h1:wv5BF9Mgjd36Xe3ocWqsb+pXko5hl8Ntdr4C0LbK6Bc=
github.com/elastic/package-spec/code/go v0.0.0-20200909122231-c8a8684bc46c/go.mod h1:baWonvawmRGxTNjrvxvPVALe4mdm7kxkni4LgOOZ3Ig=
github.com/emirpasic/gods v1.12.0 h1:QAUIPSaCu4G+POclxeqb3F+WPpdKqFGlw36+yOzGlrg=
github.com/emirpasic/gods v1.12.0/go.mod h1:YfzfFFoVP/catgzJb4IKIqXjX78Ha8FMSDh3ymbK86o=
github.com/flynn/go-shlex v0.0.0-20150515145356-3f9db97f8568 h1:BHsljHzVlRcyQhjrss6TZTdY2VfCqZPbv5k3iBFa2ZQ=
Expand Down Expand Up @@ -185,6 +187,7 @@ github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+
github.com/stretchr/objx v0.1.1/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/testify v1.2.1/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk=
github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
github.com/stretchr/testify v1.6.1 h1:hDPOHmpOpP40lSULcqw7IrRb/u7w6RpDC9399XyoNd0=
Expand All @@ -193,9 +196,16 @@ github.com/tmc/grpc-websocket-proxy v0.0.0-20190109142713-0ad062ec5ee5/go.mod h1
github.com/ugorji/go v1.1.4/go.mod h1:uQMGLiO92mf5W77hV/PUCpI3pbzQx3CRekS0kk+RGrc=
github.com/xanzy/ssh-agent v0.2.1 h1:TCbipTQL2JiiCprBWx9frJ2eJlCYT00NmctrHxVAr70=
github.com/xanzy/ssh-agent v0.2.1/go.mod h1:mLlQY/MoOhWBj+gOGMQkOeiEvkx+8pJSI+0Bx9h2kr4=
github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f h1:J9EGpcZtP0E/raorCMxlFGSTBrsSlaDGf3jU/qvAE2c=
github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f/go.mod h1:N2zxlSyiKSe5eX1tZViRH5QA0qijqEDrYZiPEAiq3wU=
github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 h1:EzJWgHovont7NscjpAxXsDA8S8BMYve8Y5+7cuRE7R0=
github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415/go.mod h1:GwrjFmJcFw6At/Gs6z4yjiIwzuJ1/+UwLxMQDVQXShQ=
github.com/xeipuuv/gojsonschema v1.2.0 h1:LhYJRs+L4fBtjZUfuSZIKGeVu0QRy8e5Xi7D17UxZ74=
github.com/xeipuuv/gojsonschema v1.2.0/go.mod h1:anYRn/JVcOK2ZgGU+IjEV4nwlhoK5sQluxsYJ78Id3Y=
github.com/xiang90/probing v0.0.0-20190116061207-43a291ad63a2/go.mod h1:UETIi67q53MR2AWcXfiuqkDkRtnGDLqkBTpCHuJHxtU=
github.com/xordataexchange/crypt v0.0.3-0.20170626215501-b2862e3d0a77/go.mod h1:aYKd//L2LvnjZzWKhF00oedf4jCCReLcmhLdhm1A27Q=
github.com/yuin/goldmark v1.1.32/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
go.etcd.io/bbolt v1.3.2/go.mod h1:IbVyRI1SCnLcuJnV2u8VeU0CEYM7e686BmAb1XKL+uU=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/multierr v1.1.0/go.mod h1:wR5kodmAFQ0UK8QlbwjlSNy0Z68gJhDJUG5sjR94q/0=
Expand All @@ -208,6 +218,8 @@ golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8U
golang.org/x/crypto v0.0.0-20200302210943-78000ba7a073/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9 h1:psW17arqaxU48Z5kZ0CQnkZWQJsqcURM6tKiBApRjXI=
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
golang.org/x/crypto v0.0.0-20200728195943-123391ffb6de h1:ikNHVSjEfnvz6sxdSPCaPt572qowuyMDMJLLm3Db3ig=
golang.org/x/crypto v0.0.0-20200728195943-123391ffb6de/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
golang.org/x/lint v0.0.0-20181026193005-c67002cb31c3/go.mod h1:UVdnD1Gm6xHRNCYTkRU2/jEulfH38KcIWyp/GAMgvoE=
golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3/go.mod h1:6SW0HCj/g11FgYtHlgUYUwCkIfeOF89ocIRzGO/8vkc=
golang.org/x/lint v0.0.0-20200302205851-738671d3881b/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
Expand All @@ -225,6 +237,8 @@ golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLL
golang.org/x/net v0.0.0-20200301022130-244492dfa37a/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
golang.org/x/net v0.0.0-20200625001655-4c5254603344 h1:vGXIOMxbNfDTk/aXCmfdLgkrSV+Z2tcbze+pEc3v5W4=
golang.org/x/net v0.0.0-20200625001655-4c5254603344/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA=
golang.org/x/net v0.0.0-20200822124328-c89045814202 h1:VvcQYSHwXgi7W+TpUR6A9g6Up98WAHf3f/ulnJ62IyA=
golang.org/x/net v0.0.0-20200822124328-c89045814202/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA=
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d h1:TzXSXBo42m9gQenoE3b9BGiEpg5IG2JkU5FkPIawgtw=
golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
Expand All @@ -245,9 +259,13 @@ golang.org/x/sys v0.0.0-20190530182044-ad28b68e88f1/go.mod h1:h1NjWce9XRLGQEsW7w
golang.org/x/sys v0.0.0-20200302150141-5c8b2ff67527/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20200323222414-85ca7c5b95cd h1:xhmwyvizuTgC2qz7ZlMluP20uW+C3Rm0FD/WLDX8884=
golang.org/x/sys v0.0.0-20200323222414-85ca7c5b95cd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20200817155316-9781c653f443 h1:X18bCaipMcoJGm27Nv7zr4XYPKGUy92GtqboKC2Hxaw=
golang.org/x/sys v0.0.0-20200817155316-9781c653f443/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.2 h1:tW2bmiBqwgJj/UpqtC8EpXEZVYOwU0yG4iWbprSVAcs=
golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
golang.org/x/text v0.3.3 h1:cokOdA+Jmi5PJGXLlLllQSgYigAEfHXJAERHVMaCc2k=
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/tools v0.0.0-20180221164845-07fd8470d635/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
Expand All @@ -256,9 +274,11 @@ golang.org/x/tools v0.0.0-20190311212946-11955173bddd/go.mod h1:LCzVGOaR6xXOjkQ3
golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
golang.org/x/tools v0.0.0-20200130002326-2f3ba24bd6e7/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28=
golang.org/x/tools v0.0.0-20200826040757-bc8aaaa29e06/go.mod h1:njjCfa9FT2d7l9Bc6FUM5FLjQPp3cFF28FI3qnDFljA=
golang.org/x/tools v0.0.0-20200831203904-5a2aa26beb65/go.mod h1:Cj7w3i3Rnn0Xh82ur9kSqwfTHTeVxaDqrfMjpcNT6bE=
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
google.golang.org/appengine v1.1.0/go.mod h1:EbEs0AVv82hx2wNQdGPgUI5lhzA/G0D9YwlJXL52JkM=
google.golang.org/appengine v1.4.0 h1:/wp5JvzpHIxhs/dumFmF7BXTf3Z+dd4uXta4kVyO508=
google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
Expand Down
2 changes: 1 addition & 1 deletion magefile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ var (
)

func Check() error {
mg.Deps(Lint)
mg.Deps(Format)
mg.Deps(Lint)
mg.Deps(Build)
mg.Deps(GenerateDocs)
mg.Deps(ModTidy)
Expand Down
1 change: 0 additions & 1 deletion packages/apache/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ type: integration
categories:
- web
release: experimental
removable: true
conditions:
kibana.version: '^7.9.0'
screenshots:
Expand Down
1 change: 0 additions & 1 deletion packages/checkpoint/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,3 @@ config_templates:
description: "Collecting firewall logs from Check Point instances (input: syslog)"
owner:
github: elastic/security-ingest
requirement: {}
1 change: 0 additions & 1 deletion packages/crowdstrike/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,3 @@ config_templates:
description: "Collecting logs from CrowdStrike Falcon (input: logfile)"
owner:
github: elastic/security-ingest
requirement: {}
1 change: 0 additions & 1 deletion packages/haproxy/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,3 @@ config_templates:
description: Collecting info and stat metrics from HAProxy instances
owner:
github: elastic/integrations
requirement: {}
1 change: 0 additions & 1 deletion packages/iis/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,3 @@ config_templates:
default: 10s
owner:
github: elastic/integrations
requirement: {}
1 change: 1 addition & 0 deletions packages/log/dataset/log/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ type: logs
name: log
streams:
- input: logfile
description: Collect your custom log files.
title: Collect log files
vars:
- name: paths
Expand Down
6 changes: 1 addition & 5 deletions packages/microsoft/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,10 @@ version: 0.1.0
description: Microsoft Integration
categories: ["network"]
release: experimental
removable: true
license: basic
type: integration
conditions:
kibana:
version: '^7.9.0'
elasticsearch:
version: '^7.9.0'
kibana.version: '^7.9.0'
config_templates:
- name: dhcp
title: Microsoft DHCP
Expand Down
1 change: 0 additions & 1 deletion packages/mongodb/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ icons:
format_version: 1.0.0
license: basic
release: experimental
removable: true
conditions:
kibana.version: '^7.9.0'
screenshots:
Expand Down
2 changes: 1 addition & 1 deletion packages/netflow/dataset/log/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ streams:
show_user: false
default: ""
- name: detect_sequence_reset
type: boolean
type: bool
title: Whether to detect sequence reset
multi: false
required: true
Expand Down
1 change: 0 additions & 1 deletion packages/prometheus/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ categories:
release: experimental
conditions:
kibana.version: ">=7.10.0"
agent.version: ">=7.10.0"
Copy link
Contributor Author

@mtojek mtojek Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrsMark is it defined on purpose here or just for potential support in the future? Once we enable deep linting, it will fail CI jobs on additional, undefined properties.

@ruflin is there support for "agent.version"? It's not defined in spec hence asking.

Copy link
Contributor

@ruflin ruflin Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have support for a required Agent version so I would remove it. But happy to have a conversation if this is needed.

screenshots:
- src: /img/metricbeat-prometheus-overview.png
title: Metricbeat Prometheus Overview
Expand Down
1 change: 0 additions & 1 deletion packages/rabbitmq/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ type: integration
categories:
- message_queue
release: experimental
removable: true
conditions:
kibana.version: '^7.9.0'
icons:
Expand Down
3 changes: 1 addition & 2 deletions packages/synthetics/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ config_templates:
title: Monitor
description: Perform synthetic monitor checks
conditions:
kibana:
version: "^7.10.0"
kibana.version: "^7.10.0"
icons:
- src: /img/uptime-logo-color-64px.svg
size: 16x16
Expand Down
8 changes: 4 additions & 4 deletions packages/system/dataset/process/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ streams:
Include the top N processes by memory usage.

- name: process.cmdline.cache.enabled
type: boolean
type: bool
title: Enable cmdline cache
multi: false
required: false
Expand All @@ -42,7 +42,7 @@ streams:
If false, cmdline of a process is not cached.

- name: process.cgroups.enabled
type: boolean
type: bool
title: Enable cgroup reporting
multi: false
required: false
Expand All @@ -52,7 +52,7 @@ streams:
Enable collection of cgroup metrics from processes on Linux.

- name: process.env.whitelist
type: keyword
type: text
title: Env whitelist
multi: true
required: false
Expand All @@ -62,7 +62,7 @@ streams:
with the process metricset's events. Defaults to empty.

- name: process.include_cpu_ticks
type: boolean
type: bool
title: Include CPU Ticks
multi: false
required: false
Expand Down
6 changes: 3 additions & 3 deletions packages/system/dataset/socket/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ streams:
show_user: true
default: 10s
- name: socket.reverse_lookup.enabled
type: boolean
type: bool
title: Enable Reverse Lookup
multi: false
required: false
Expand All @@ -22,7 +22,7 @@ streams:
Configure reverse DNS lookup on remote IP addresses in the socket metricset.

- name: socket.reverse_lookup.success_ttl
type: duration
type: integer
title: Reverse Lookup Success TTL
multi: false
required: false
Expand All @@ -31,7 +31,7 @@ streams:
Success TTL for reverse DNS lookup on remote IP addresses in the socket metricset.

- name: socket.reverse_lookup.failure_ttl
type: duration
Copy link
Contributor Author

@mtojek mtojek Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruflin we don't support "duration" type, right?

Copy link
Contributor

@ruflin ruflin Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jen-huang Can you comment on this? I know we played with the idea. Would it be useful to have it?

Copy link
Contributor Author

@mtojek mtojek Sep 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's rather question - whether it's supported at the moment :)

According to the reference package, it's not: https://github.com/elastic/package-registry/blob/33c9f9df5881a879ced083cc626ba973f928b32d/testdata/package/reference/1.0.0/dataset/reference/manifest.yml#L47

Copy link
Contributor Author

@mtojek mtojek Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will merge the fix to prevent potential merge conflicts. In case of emergency I will open another PR.

Copy link
Contributor

@jen-huang jen-huang Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the UI only differentiates between type yaml and not-yaml. Not-yaml fields are treated as text, so right now we technically support "any" type. I think we had an initial list of other types for future UI improvements (special inputs, specific validation, etc), but we haven't gotten around to those improvements yet.

IMO it would be good to keep this duration type around if we expect this sort of field to be fairly common in multiple packages. It won't break anything in the UI. Or maybe we should circle back and adjust the initial type list we made, now that packages are more fleshed out?

Copy link
Contributor Author

@mtojek mtojek Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding, Jen. I understand this may need some prioritization. /cc @ruflin @ph

Copy link
Contributor

@ruflin ruflin Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make validation possible, I suggest we only use the ones supported and if we add a new one adjust the packages. Otherwise we suddenly have "magical" changes. No new packages was released but it looks now different.

@mtojek What are the types you are missing at the moment? Lets create a list with the priority.

Copy link
Contributor Author

@mtojek mtojek Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elastic/package-spec#44

type: integer
title: Reverse Lookup Success TTL
multi: false
required: false
Expand Down
1 change: 0 additions & 1 deletion packages/windows/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ icons:
format_version: 1.0.0
license: basic
release: experimental
removable: true
conditions:
kibana.version: '^7.9.0'
screenshots:
Expand Down