Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

Proposed commit message

cisco_secure_endpoint: prevent updating fleet health status to degraded when HTTPJSON template value
evaluation failed and update the system test to correctly match hit counts.

This change bumps minimum kibana version to ^8.19.4 || ~9.0.7 || ^9.1.4 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cisco_secure_endpoint directory.
  • Run the following command to run tests.

elastic-package test

Related issues

@brijesh-elastic brijesh-elastic self-assigned this Nov 24, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner November 24, 2025 07:50
@brijesh-elastic brijesh-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:cisco_secure_endpoint Cisco Secure Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Nov 24, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @brijesh-elastic

@efd6 efd6 changed the title [cisco_secure_endpoint] Fix the template evaluation issue and update the system test to correctly match hit counts [cisco_secure_endpoint] Fix template field indexing issue Nov 24, 2025
@efd6 efd6 changed the title [cisco_secure_endpoint] Fix template field indexing issue [cisco_secure_endpoint] fix template field indexing when next link is absent Nov 24, 2025
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested commit message:

cisco_secure_endpoint: fix template field indexing when next link is absent

Don't updating fleet health status to degraded when HTTPJSON template
evaluation fails due to an absent metadata.links.next field.

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

# newer versions go on top
- version: "2.33.0"
changes:
- description: Prevent updating fleet health status to degraded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Prevent updating fleet health status to degraded.
- description: Prevent updating fleet health status to degraded when no next link is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:cisco_secure_endpoint Cisco Secure Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants