Skip to content

feat(okta): add rate_limit_early_limit configuration #15835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(okta): add rate_limit_early_limit configuration #15835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/okta/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "3.11.0"
changes:
- description: Added support for rate_limit_early_limit configuration to start rate-limiting before reaching the API response limit.
type: enhancement
link: https://github.com/elastic/integrations/pull/15835
- version: "3.10.3"
changes:
- description: Optimize API pagination to prevent unnecessary requests when fewer logs than the limit are returned, reducing rate limit token consumption.
Expand Down
3 changes: 3 additions & 0 deletions packages/okta/data_stream/system/agent/stream/httpjson.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ request.rate_limit:
limit: '[[.last_response.header.Get "X-Rate-Limit-Limit"]]'
remaining: '[[.last_response.header.Get "X-Rate-Limit-Remaining"]]'
reset: '[[.last_response.header.Get "X-Rate-Limit-Reset"]]'
{{#if rate_limit_early_limit}}
early_limit: {{rate_limit_early_limit}}
{{/if}}

{{#if ssl}}
request.ssl: {{ssl}}
Expand Down
7 changes: 7 additions & 0 deletions packages/okta/data_stream/system/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ streams:
# This works around system tests not allowing an assert.hit_count > 500.
- default
- agentless
- name: rate_limit_early_limit
title: Rate Limit Early Limit
description: Start rate-limiting before reaching the limit specified in the response. Values less than 1 are treated as a percentage of the limit (e.g. 0.9 means 90%). Values greater than or equal to 1 are treated as the target remaining value.
type: text
required: false
show_user: false
secret: false

template_path: httpjson.yml.hbs
title: Okta system logs
Expand Down
8 changes: 2 additions & 6 deletions packages/okta/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: okta
title: Okta
version: "3.10.3"
version: "3.11.0"
description: Collect and parse event logs from Okta API with Elastic Agent.
type: integration
format_version: "3.2.3"
Expand Down Expand Up @@ -149,11 +149,7 @@ policy_templates:
required: false
show_user: false
description: >-
The request tracer logs requests and responses to the agent's local file-system for debugging configurations.
Enabling this request tracing compromises security and should only be used for debugging. Disabling the request
tracer will delete any stored traces.
See [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html#_request_tracer_filename)
for details.
The request tracer logs requests and responses to the agent's local file-system for debugging configurations. Enabling this request tracing compromises security and should only be used for debugging. Disabling the request tracer will delete any stored traces. See [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html#_request_tracer_filename) for details.
- name: ssl
type: yaml
title: SSL
Expand Down