Skip to content

Conversation

@stefans-elastic
Copy link
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@stefans-elastic stefans-elastic self-assigned this Oct 10, 2025
@stefans-elastic stefans-elastic added enhancement New feature or request Integration:kafka Kafka Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Oct 10, 2025
@stefans-elastic
Copy link
Contributor Author

/test

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@stefans-elastic stefans-elastic marked this pull request as ready for review October 14, 2025 06:49
@stefans-elastic stefans-elastic requested a review from a team as a code owner October 14, 2025 06:49
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments

@@ -0,0 +1,44 @@
FROM debian:stretch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image has reached EOL. Do you want to consider using a different image?

Ref: https://www.debian.org/releases/

Copy link
Contributor Author

@stefans-elastic stefans-elastic Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older Kafka (and older Jolokia agent) requires older java and I wasn't successful in installing old java on newer image and that's why in this case I went with older image.

Comment on lines 14 to 18
RUN sed -i s/deb.debian.org/archive.debian.org/g /etc/apt/sources.list \
&& sed -i 's|security.debian.org|archive.debian.org/|g' /etc/apt/sources.list \
&& sed -i '/stretch-updates/d' /etc/apt/sources.list

RUN apt-get update && apt-get upgrade -y && apt-get install -y curl openjdk-8-jre-headless netcat-openbsd dnsutils procps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Combine them to reduce the image layers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,44 @@
FROM debian:stretch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image has reached EOL. Do you want to consider using a different image?

Ref: https://www.debian.org/releases/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much same situation as in #15629 (comment)

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @stefans-elastic

@stefans-elastic stefans-elastic merged commit d01f509 into elastic:main Oct 23, 2025
7 checks passed
@stefans-elastic stefans-elastic deleted the kafka-tests-variants branch October 23, 2025 12:29
agithomas pushed a commit to agithomas/integrations that referenced this pull request Oct 30, 2025
* add kafka 4.0.0 test variant

* kafka 3.6.0 variant

* add more variants

* cover kafka 0.10.2.1 and kafka 1.1.0 in system test variants

* yaml format fix

* yaml format fix

* yaml format fix

* oprimize docker image building
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:kafka Kafka Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants