-
Notifications
You must be signed in to change notification settings - Fork 511
Kafka system tests variants #15629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka system tests variants #15629
Conversation
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added review comments
| @@ -0,0 +1,44 @@ | |||
| FROM debian:stretch | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image has reached EOL. Do you want to consider using a different image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Older Kafka (and older Jolokia agent) requires older java and I wasn't successful in installing old java on newer image and that's why in this case I went with older image.
| RUN sed -i s/deb.debian.org/archive.debian.org/g /etc/apt/sources.list \ | ||
| && sed -i 's|security.debian.org|archive.debian.org/|g' /etc/apt/sources.list \ | ||
| && sed -i '/stretch-updates/d' /etc/apt/sources.list | ||
|
|
||
| RUN apt-get update && apt-get upgrade -y && apt-get install -y curl openjdk-8-jre-headless netcat-openbsd dnsutils procps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Combine them to reduce the image layers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| @@ -0,0 +1,44 @@ | |||
| FROM debian:stretch | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image has reached EOL. Do you want to consider using a different image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much same situation as in #15629 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
History
|
* add kafka 4.0.0 test variant * kafka 3.6.0 variant * add more variants * cover kafka 0.10.2.1 and kafka 1.1.0 in system test variants * yaml format fix * yaml format fix * yaml format fix * oprimize docker image building
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots