Skip to content

Conversation

elastic-vault-github-plugin-prod[bot]

Update elastic-package reference to elastic/elastic-package@b17eca9.
Automated by Buildkite build

Relates: elastic/elastic-package#2980

@elasticmachine
Copy link

elasticmachine commented Oct 9, 2025

@andrewkroh
Copy link
Member

These are the failures:

abnormal_security.ai_security_mailbox_not_analyzed

  • Package policy is invalid: inputs.cel.streams.abnormal_security.ai_security_mailbox_not_analyzed.vars.wait_interval: Recent Message Grace Interval is required

aws_bedrock.invocation

  • Package policy is invalid: inputs.aws-s3.streams.aws_bedrock.invocation.vars.file_selectors: Invalid format for File Selectors: expected array

crowdstrike.fdr

  • Package policy is invalid: inputs.aws-s3.streams.crowdstrike.fdr.vars.queue_url: Queue URL is required

nvidia_gpu.stats

  • Package policy is invalid: inputs.prometheus/metrics.streams.nvidia_gpu.stats.vars.ssl: Invalid format for SSL Configuration: expected array

@andrewkroh
Copy link
Member

I believe that these failures represent the correct behavior for a system test that doesn't define a required variable. I find it surprising that the Fleet API permits null values (e.g., {"vars":{"proxy_url":{"value":null,"type":"url"}}}) to meet the required variable constraint1. The specification doesn't specify that "required" means non-null, so this behavior is acceptable. However, most systems I'm familiar with include an explicit nullable property that's disabled by default (as seen in JSON Schema, OpenAPI, and Terraform variables), meaning required variables must be non-null unless null has been explicitly allowed.

I think the solution should involve updating these system tests to define the required variables they intend to use during testing. They can continue using null, but they must explicitly set it in their system test configuration, such as wait_interval: null. We can continue with elastic/elastic-package#2980 as long as we update the 4 system tests before the elastic-package version bump.

Footnotes

  1. https://github.com/elastic/package-spec/blob/1b68ab354d55fa1c76de0058cc55b75a48242cdf/spec/integration/data_stream/manifest.spec.yml#L111-L112

@jsoriano
Copy link
Member

I think the solution should involve updating these system tests to define the required variables they intend to use during testing. They can continue using null, but they must explicitly set it in their system test configuration, such as wait_interval: null. We can continue with elastic/elastic-package#2980 as long as we update the 4 system tests before the elastic-package version bump.

Agree, let's continue with elastic/elastic-package#2980.

@jsoriano jsoriano closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants