-
Notifications
You must be signed in to change notification settings - Fork 515
Fix pagination in 1Password Audit collection #15407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pagnination does not work, elastic-agnet goes rampid and makes way to many requests against the 1password api. Pagination should be same as the other streams.
|
💚 CLA has been signed |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
chemamartinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me! However, I think one more change is required in order to keep the system tests working.
Now that the has_more controls the pagination, in this mock response, has_more value should be true so the test makes the second request and ingest the two expected events.
|
@hellqvio86 also the integration's version should be increased (to 1.33.1) and a changelog entry is required. |
chemamartinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version needs to be updated in the package manifest as well.
Co-authored-by: Chema Martínez <chema.martinez@elastic.co>
|
@hellqvio86 do you need some assistance for adding the requested changes? I've seen some activity since my last review but still missing some changes. |
I just updated the manifest is there anything else that I have missed? 🙂 |
I don't see the change that I mentioned at #15407 (review). |
has_more is true on line 107 in packages/1password/_dev/deployer/docker/config.yml
|
Sorry, it's true. I didn't see the change in this PR anymore because last week they added the same change: #15415 It seems that the mentioned PR already fixes the pagination for the Do you mind to close it? |
Pagnination does not work, elastic-agnet goes rampid and makes way to many requests against the 1password api. Pagination should be same as the other streams.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots