Skip to content

Conversation

@gpop63
Copy link
Contributor

@gpop63 gpop63 commented Sep 18, 2025

Overview

Adds documentation and dashboard for collecting AWS ELB access logs with the EDOT Cloud Forwarder.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

  • Closes elastic/obs-integration-team/issues/583

Screenshots

image image

@gpop63 gpop63 requested a review from a team as a code owner September 18, 2025 19:25
@gpop63 gpop63 self-assigned this Sep 18, 2025
@gpop63 gpop63 added New Integration Issue or pull request for creating a new integration package. dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Sep 18, 2025
@gpop63 gpop63 requested a review from ishleenk17 September 18, 2025 19:26
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Sep 18, 2025
use esql queries in dashboard
@gpop63 gpop63 changed the title [elb_otel] Add AWS ELB logs content pack for OpenTelemetry [aws_elb_otel] Add AWS ELB logs content pack for OpenTelemetry Sep 19, 2025
@ishleenk17
Copy link
Member

@gpop63 : Can you also share the screenshot of Elastic ELB Logs dashboard.

@ishleenk17
Copy link
Member

ishleenk17 commented Sep 22, 2025

@gpop63 : Yet to review the dashboard. But shared other reviews.

  1. The logo also, lets have one with ELB and OTEL image in the bottom. Refer to other OTEL Content Packs.


For the full documentation on how to set up the EDOT Cloud Forwarder, follow this link: [EDOT Cloud Forwarder for AWS](https://www.elastic.co/docs/reference/opentelemetry/edot-cloud-forwarder/aws).

## Requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc team uses new namings for sections, like "What do I need to use this integration?" instead of "Requirements". There are more source

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though this is not an integration. Not sure if the new one is good here

* An Elastic **OTLP endpoint** and **API key** for authentication.

## Setup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpop63 : We can mention like this for the config of ECF rather than mentioning the details in our CP.
Our CP aims to have dashboards. These config informations should be just FYI, high level

@ishleenk17
Copy link
Member

NOTE: Once this PR is included in the ECOT Collector, we should change the dashboard filter to
scope.attributes.awslogs_encoding.format: elb_access_log

@gpop63
Copy link
Contributor Author

gpop63 commented Sep 22, 2025

Can you also share the screenshot of Elastic ELB Logs dashboard.

@ishleenk17

This is Elastic ELB dashboard

image

OTEL dashboard

I have a widescreen thats why it seems more compact.

elb_dashboard

@ishleenk17
Copy link
Member

@gpop63 : Comments on the dashboard

  1. Inbound and outbound traffic doens't showcase which one is inbound which is outbound. Also the y axis says response size. Is that correct ?
  2. Y axis for status code should be Count.
  3. Y axis for total requests should be Count.
  4. Top IP addresses. Are we saying the IP addresses are in ocunt of 60K etc in the graph. Is there a better represeatation for this . Also, can we have maybe the top 10. Currently it looks cluttered.
  5. Totle of dashboard doesn't have mention of OTEL in it.
  6. In elastic dashboard I see different panels for ALB and ELB Inbound/outbound traffic. Are these different . Are the fields for these different ?

@mykola-elastic
Copy link
Contributor

The first screenshot (integration page) in the PR description is low resolution

@mykola-elastic
Copy link
Contributor

For the dashboard screenshot it would be good to have generate some data also in the 2xx and 5xx panels

@gpop63
Copy link
Contributor Author

gpop63 commented Sep 26, 2025

@daniela-elastic updated the dashboard 👍

elb_dashboard

@tommyers-elastic
Copy link
Contributor

small nit - can we not say "content pack" in the text? whilst this dashboard is getting shipped in a content pack, the dashboard itself is still just a dashboard.

@elastic-sonarqube
Copy link

gpop63 and others added 2 commits October 17, 2025 10:26
Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co>
"meta": {
"alias": null,
"disabled": false,
"field": "awslogs_encoding.format",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field does not exist anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpop63 That is still not removed

"meta": {
"alias": null,
"disabled": false,
"field": "awslogs_encoding.format",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpop63 That is still not removed

@MichaelKatsoulis MichaelKatsoulis self-requested a review October 21, 2025 08:41
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nit readme update!

Co-authored-by: Michalis Katsoulis <michaelkatsoulis88@gmail.com>
@ishleenk17
Copy link
Member

@gpop63 : I see that we have used the dataset filter at panel level and not global level.
Any reason for that ?

@gpop63 : I was checking in the dashboard, there is no mention of the word "OpenTelemetry" in the title, description of the dashboard. Anyone looking at just the dashboard will not get to know it is having OTEL data.

Do we have this present somewhere ?

@gpop63
Copy link
Contributor Author

gpop63 commented Oct 22, 2025

@gpop63 : I see that we have used the dataset filter at panel level and not global level.
Any reason for that ?

Initially there was no data stream filter we could use globally, so I added filters at panel level for safety and consistency but we could remove them without any issue right now.

@gpop63 : I was checking in the dashboard, there is no mention of the word "OpenTelemetry" in the title, description of the dashboard. Anyone looking at just the dashboard will not get to know it is having OTEL data.

OTEL keyword is part of the dashboard title.

@ishleenk17
Copy link
Member

Initially there was no data stream filter we could use globally, so I added filters at panel level for safety and consistency but we could remove them without any issue right now.

Yes lets do that.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @gpop63

Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gpop63 gpop63 merged commit 6bd3578 into elastic:main Oct 23, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package aws_elb_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/aws_elb_otel/0.1.0/

@andrewkroh andrewkroh added the Integration:aws_elb_otel AWS ELB OpenTelemetry Assets label Oct 23, 2025
agithomas pushed a commit to agithomas/integrations that referenced this pull request Oct 30, 2025
…ic#15401)

* add content pack

* fix pr id

* add codeowners entry

* fix codeowners

* rename integration to aws_elb_otel
use esql queries in dashboard

* fix codeowners entry

* update logo

* update dashboard title
fix field names

* update docs

* add dashboard datastream filter

* fix dashboard filter

* address comments

* use bytes for y axis

* Update packages/aws_elb_otel/changelog.yml

Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co>

* update dashboard

* update dashboard

* remove content pack from title

* Update packages/aws_elb_otel/manifest.yml

Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co>

* update data stream filter

* fix datastream filters

* fix datastream filter

* Update packages/aws_elb_otel/docs/README.md

Co-authored-by: Michalis Katsoulis <michaelkatsoulis88@gmail.com>

* remove datastream filter at lens lvl

---------

Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co>
Co-authored-by: Michalis Katsoulis <michaelkatsoulis88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:aws_elb_otel AWS ELB OpenTelemetry Assets New Integration Issue or pull request for creating a new integration package. Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants