-
Notifications
You must be signed in to change notification settings - Fork 511
[aws_elb_otel] Add AWS ELB logs content pack for OpenTelemetry #15401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
use esql queries in dashboard
|
@gpop63 : Can you also share the screenshot of Elastic ELB Logs dashboard. |
|
@gpop63 : Yet to review the dashboard. But shared other reviews.
|
packages/aws_elb_otel/docs/README.md
Outdated
|
|
||
| For the full documentation on how to set up the EDOT Cloud Forwarder, follow this link: [EDOT Cloud Forwarder for AWS](https://www.elastic.co/docs/reference/opentelemetry/edot-cloud-forwarder/aws). | ||
|
|
||
| ## Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc team uses new namings for sections, like "What do I need to use this integration?" instead of "Requirements". There are more source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though this is not an integration. Not sure if the new one is good here
packages/aws_elb_otel/docs/README.md
Outdated
| * An Elastic **OTLP endpoint** and **API key** for authentication. | ||
|
|
||
| ## Setup | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
NOTE: Once this PR is included in the ECOT Collector, we should change the dashboard filter to |
|
@gpop63 : Comments on the dashboard
|
|
The first screenshot (integration page) in the PR description is low resolution |
|
For the dashboard screenshot it would be good to have generate some data also in the 2xx and 5xx panels |
|
@daniela-elastic updated the dashboard 👍
|
|
small nit - can we not say "content pack" in the text? whilst this dashboard is getting shipped in a content pack, the dashboard itself is still just a dashboard. |
|
Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co>
packages/aws_elb_otel/kibana/dashboard/aws_elb_otel-918bae2f-9268-46da-acac-7f4029ca0bfa.json
Outdated
Show resolved
Hide resolved
| "meta": { | ||
| "alias": null, | ||
| "disabled": false, | ||
| "field": "awslogs_encoding.format", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field does not exist anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpop63 That is still not removed
| "meta": { | ||
| "alias": null, | ||
| "disabled": false, | ||
| "field": "awslogs_encoding.format", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpop63 That is still not removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a nit readme update!
Co-authored-by: Michalis Katsoulis <michaelkatsoulis88@gmail.com>
|
@gpop63 : I see that we have used the dataset filter at panel level and not global level. @gpop63 : I was checking in the dashboard, there is no mention of the word "OpenTelemetry" in the title, description of the dashboard. Anyone looking at just the dashboard will not get to know it is having OTEL data. Do we have this present somewhere ? |
Initially there was no data stream filter we could use globally, so I added filters at panel level for safety and consistency but we could remove them without any issue right now.
OTEL keyword is part of the dashboard title. |
Yes lets do that. |
💚 Build Succeeded
History
cc @gpop63 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Package aws_elb_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/aws_elb_otel/0.1.0/ |
…ic#15401) * add content pack * fix pr id * add codeowners entry * fix codeowners * rename integration to aws_elb_otel use esql queries in dashboard * fix codeowners entry * update logo * update dashboard title fix field names * update docs * add dashboard datastream filter * fix dashboard filter * address comments * use bytes for y axis * Update packages/aws_elb_otel/changelog.yml Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co> * update dashboard * update dashboard * remove content pack from title * Update packages/aws_elb_otel/manifest.yml Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co> * update data stream filter * fix datastream filters * fix datastream filter * Update packages/aws_elb_otel/docs/README.md Co-authored-by: Michalis Katsoulis <michaelkatsoulis88@gmail.com> * remove datastream filter at lens lvl --------- Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co> Co-authored-by: Michalis Katsoulis <michaelkatsoulis88@gmail.com>







Overview
Adds documentation and dashboard for collecting AWS ELB access logs with the EDOT Cloud Forwarder.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots