o365: fix handling of error conditions when requesting work continuation #15380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Integration:o365
CEL type(o.f) == T does not work the same way as painless o.f instanceof T if f is not in o. It is necessary to check for existence first. In this case, this can be done either by directly checking for the existence of events in state, or because of an invariant in the program, by the absence of error in state. The latter is chosen for clarity and to ensure that the invariant is kept.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
Package o365 - 2.29.1 containing this change is available at https://epr.elastic.co/package/o365/2.29.1/ |
5 tasks
tehbooom
pushed a commit
to tehbooom/integrations
that referenced
this pull request
Nov 19, 2025
…ion (elastic#15380) CEL type(o.f) == T does not work the same way as painless o.f instanceof T if f is not in o. It is necessary to check for existence first. In this case, this can be done either by directly checking for the existence of events in state, or because of an invariant in the program, by the absence of error in state. The latter is chosen for clarity and to ensure that the invariant is kept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots