Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Sep 15, 2025

Proposed commit message

o365: tolerate changed API next page URI behaviour

The API now returns the next page URI with the parameters lowercased.
This is not documented[1], so retain support for the document behaviour.

[1]https://learn.microsoft.com/en-us/office/office-365-management-api/office-365-management-activity-api-reference

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Sep 15, 2025
@efd6 efd6 added enhancement New feature or request Integration:o365 Microsoft Office 365 bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Sep 15, 2025
The API now returns the next page URI with the parameters lowercased.
This is not documented[1], so retain support for the document behaviour.

[1]https://learn.microsoft.com/en-us/office/office-365-management-api/office-365-management-activity-api-reference
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@elastic-sonarqube
Copy link

@efd6 efd6 marked this pull request as ready for review September 15, 2025 21:43
@efd6 efd6 requested a review from a team as a code owner September 15, 2025 21:43
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@efd6 efd6 merged commit 9e9da32 into elastic:main Sep 16, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Package o365 - 2.29.0 containing this change is available at https://epr.elastic.co/package/o365/2.29.0/

Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
The API now returns the next page URI with the parameters lower-cased.
This is not documented[1], so also retain support for the documented
behaviour.

[1]https://learn.microsoft.com/en-us/office/office-365-management-api/office-365-management-activity-api-reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants