Skip to content

[Enhancement] Update categories for packages #14571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Sep 17, 2025
Merged

[Enhancement] Update categories for packages #14571

merged 27 commits into from
Sep 17, 2025

Conversation

@trisch-me
Copy link
Contributor

@trisch-me trisch-me commented Jul 16, 2025 •
edited
Loading

We are using categories of packages in telemetry and it seems that categories of packages are not reliable as I found a few of security packages not marked as such, for example aws etc.

I took advantage of LLM to update the list of categories according to the readme in each integration and using this list of available categories

I have verified it as much as I could but as it touches a lot of integrations it would be great to have more eyes on it.
Every new category has justification

p.s. I am new to the integrations development so it might be I’m missing some of the usages of categories and current changes might break something. If so - I am happy to update the PR

FYI @vglagoleva @andrewkroh

@trisch-me trisch-me added the enhancement New feature or request label Jul 16, 2025
@trisch-me trisch-me requested review from a team as code owners July 16, 2025 16:28
@trisch-me trisch-me requested review from leehinman and rdner July 16, 2025 16:28
leehinman
leehinman approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the changes to "windows" package since that is the only one owned by elastic-agent-data-plane.

susan-shu-c
susan-shu-c approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@susan-shu-c susan-shu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the network_security category in packages/beaconing should work; cc @sodhikirti07

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 16, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

andrewkroh
andrewkroh reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without elastic/package-spec providing any description of the category meanings, there is some subjectivity to the labeling. I have brought my own assumptions to this review.

Overall looks good, it probably would be good for PMs that know these products to also have a look.

@andrewkroh andrewkroh added Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Applied ML Elastic Security Protections Machine Learning (ML) team [elastic/sec-applied-ml] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] Integration:All Applies to all integrations [Integration not found in source] labels Jul 16, 2025
@daniela-elastic
Copy link

hey @daniela-elastic I agree with you, it was automated update based on this structure where for example Kubernetes or web is a subcategory for observability. Should we revisit then this tree as well?

Yes, agree this should be revisited, especially if it drives decisions on how to categorise each integration

@trisch-me
Copy link
Contributor Author

@daniela-elastic should I remove latest changes then in this PR for it to be merged?

daniela-elastic
daniela-elastic reviewed Sep 12, 2025
View reviewed changes
daniela-elastic
daniela-elastic approved these changes Sep 12, 2025
View reviewed changes
Copy link

@daniela-elastic daniela-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments to address. No need for another review though, so approved and we can discuss these two questions offline

@trisch-me
Copy link
Contributor Author

Resolved both of the comments (by adding requested category)

@trisch-me
Copy link
Contributor Author

@shmsr could please update your review?

@trisch-me
Copy link
Contributor Author

@elastic/obs-ux-management-team @elastic/ml-ui @elastic/obs-ds-intake-services @elastic/search-extract-and-transform @elastic/integration-experience

could I get your review for this PR?

peteharverson
peteharverson approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ml-ui owned change to beaconing package categories LGTM.

@trisch-me trisch-me enabled auto-merge (squash) September 16, 2025 11:25
mgiota
mgiota approved these changes Sep 17, 2025
View reviewed changes
Copy link

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @shahzad31 Not sure how to do the testing manually though. Does this look good to you?

ericywl
ericywl approved these changes Sep 17, 2025
View reviewed changes
Copy link

@ericywl ericywl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for apm

@trisch-me trisch-me merged commit 3c176af into elastic:main Sep 17, 2025
7 checks passed
@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
77.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Sep 17, 2025
@trisch-me @robester0403
[Enhancement] Update categories for packages (elastic#14571)
243be30 
* update category

* update according to the comments

* more comments from PR

* added security global category to those packages that are related to security

* make all integrations having parent category

* add observability to another package

* introduce final comments
@shashank-elastic shashank-elastic mentioned this pull request Sep 18, 2025
Merged
5 tasks
@JDKurma JDKurma mentioned this pull request Oct 9, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florianl florianl florianl approved these changes

@gizas gizas gizas approved these changes

@mgiota mgiota mgiota approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@peteharverson peteharverson peteharverson approved these changes

@artem-shelkovnikov artem-shelkovnikov artem-shelkovnikov approved these changes

@ericywl ericywl ericywl approved these changes

@susan-shu-c susan-shu-c susan-shu-c approved these changes

@shmsr shmsr shmsr approved these changes

@leehinman leehinman leehinman approved these changes

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@daniela-elastic daniela-elastic daniela-elastic approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Integration:All Applies to all integrations [Integration not found in source] Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Search-Extract and Transform Search - Extract and Transform team [elastic/search-extract-and-transform] Team:Security-Applied ML Elastic Security Protections Machine Learning (ML) team [elastic/sec-applied-ml] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.