Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages/microsoft_sqlserver: Improve documentation #11646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

packages/microsoft_sqlserver: Improve documentation #11646

wants to merge 2 commits into from

Conversation

shmsr
Copy link
Member

@shmsr shmsr commented Nov 5, 2024 •
edited
Loading

Proposed commit message

Improve documentation to elaborate more on permissions. This PR also includes some general improvements to the documentation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@shmsr shmsr self-assigned this Nov 5, 2024
@shmsr shmsr requested a review from a team as a code owner November 5, 2024 20:12
@shmsr shmsr added Integration:microsoft_sqlserver Microsoft SQL Server enhancement New feature or request docs labels Nov 5, 2024
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Nov 5, 2024
@shmsr @andrewkroh
Update packages/microsoft_sqlserver/changelog.yml
f87c59e 
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @shmsr

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@shmsr shmsr

Labels
docs enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shmsr @elasticmachine @andrewkroh