Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] add support to include linked accounts when using log name prefix to select log groups #11484

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[AWS] add support to include linked accounts when using log name prefix to select log groups #11484

wants to merge 1 commit into from

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Oct 21, 2024 •
edited
Loading

Proposed commit message

Adds support to include linked accounts when using Log Group Name Prefix to select the desired log groups to monitor.

The boolean option Include Linked Accounts with prefix is disabled by default and internally maps to filebeat input include_linked_accounts_for_prefix_mode.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

image

@Kavindu-Dodan Kavindu-Dodan added enhancement New feature or request Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Oct 21, 2024
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 21, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/aws-linked-accounts-for-prefix-mode branch 3 times, most recently from dd5efc3 to 689e5fc Compare October 24, 2024 17:03
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/aws-linked-accounts-for-prefix-mode branch 4 times, most recently from 03a1d8b to 6d8b3f8 Compare November 4, 2024 20:43
@Kavindu-Dodan
add support to include linked accounts when using log name prefix
f3be5ec 
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

add changelog link

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

trigger build

# Conflicts:
#	packages/aws/changelog.yml
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/aws-linked-accounts-for-prefix-mode branch from 6d8b3f8 to f3be5ec Compare November 7, 2024 16:39
@Kavindu-Dodan Kavindu-Dodan marked this pull request as ready for review November 7, 2024 16:39
@Kavindu-Dodan Kavindu-Dodan requested review from a team as code owners November 7, 2024 16:39
@Kavindu-Dodan Kavindu-Dodan changed the title [Draft] [AWS] add support to include linked accounts when using log name prefix to select log groups [AWS] add support to include linked accounts when using log name prefix to select log groups Nov 7, 2024
@andrewkroh andrewkroh added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Nov 7, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@Kavindu-Dodan Kavindu-Dodan marked this pull request as draft November 7, 2024 17:15
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
85.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request Integration:aws_bedrock Amazon Bedrock Integration:aws_logs Custom AWS Logs Integration:aws AWS Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS] Support linked accounts when using log_group_name_prefix to select log groups
3 participants
@Kavindu-Dodan @elasticmachine @andrewkroh