-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure logs] use one input + routing for all data streams (WIP) #11432
Draft
zmoog
wants to merge
6
commits into
elastic:main
Choose a base branch
from
zmoog:zmoog/one-input-to-rule-them-all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer have one input per data stream, so we must remove all the input related settings.
zmoog
added
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services]
enhancement
New feature or request
Integration:azure
Azure Logs
labels
Oct 16, 2024
zmoog
changed the title
[azure logs] use one input for all data streams + routing (WIP)
[azure logs] use one input + routing for all data streams (WIP)
Oct 16, 2024
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
provisioning |
3558.72 | 2288.33 | -1270.39 (-35.7%) | 💔 |
platformlogs |
5917.16 | 4524.89 | -1392.27 (-23.53%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
cc @zmoog |
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Integration:azure
Azure Logs
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Switch the integration package from the one-input-per-data-stream model to the one-input model.
One input per data stream model:
One input model:
In the one-input model, there is only one azure-eventhub input running and sending events to the
events
data stream. In theevents
data stream, the ingest pipeline performs these tasks:event.dataset
field using thecategory
field in the event.event.dataset
field to reroute the event to the target data stream.The discover process uses the following logic:
event.dataset
toazure.eventhub
(the generic integration)event.dataset
toazure.platformlogs
(it's probably an Azure log)event.dataset
to specific one likeazure.activitylogs
orazure.signinlogs
.After the discovery step, the routing rules use the
event.dataset
value to forward the events to the best available target data stream.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots