[cisco_asa] Remove test for missing message_id #11191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Customer reported a check for a missing message_id was causing failures in processing. * This check was removed and verified that no existing tests failed. * Customer did not provide sample data, so this is guesswork.
andrewkroh
added
Integration:cisco_asa
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "2.37.1" | |||
| changes: | |||
| - description: "Customer is having poor experience when logs are missing message_id field." | |||
There was a problem hiding this comment.
Suggested change
| - description: "Customer is having poor experience when logs are missing message_id field." | |
| - description: "Remove erroneous check for empty message ID in kv processor." |
We don't need to mention a customer.
|
SDH was closed; no idea if this was a theoretical problem or an actual one. Closing this, because it wasn't ready anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
[cisco_asa] Remove check for missing message_id
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots