Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes] Include kubeadm parameter #11187

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Kubernetes] Include kubeadm parameter #11187

wants to merge 4 commits into from

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Sep 19, 2024

  • Enhancement

Proposed commit message

WHAT: Adding use_kubeadm variable in all the datastreams of kubernetes integrations
WHY: As per elastic/beats#40276

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Clone this repo
  2. Navigate to elastic/integrations/packages/kubernetes
  3. Build integration with elastic-package build command
  4. Within the same folder run elastic-package stack up -d -v --version=8.16.0-SNAPSHOT
  5. Open Local kibana page and install Kubernetes Integration v1.68.0. The use_kubeadm option should be available

Related issues

NOTE: I would like to run some tests with sue_kubeadm: false and elastic agent to verify the actual gain we have by disabling those commands

Screenshots

@gizas gizas requested a review from a team as a code owner September 19, 2024 13:50
@andrewkroh andrewkroh added Integration:kubernetes Kubernetes Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] labels Sep 19, 2024
@gizas gizas removed the Integration:kubernetes Kubernetes label Sep 19, 2024
@gizas gizas changed the title adding the files to include kubeadm parameter [Kubernetes] Include kubeadm parameter Sep 20, 2024
@andrewkroh andrewkroh added the enhancement New feature or request label Sep 20, 2024
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@botelastic
Copy link

botelastic bot commented Oct 25, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:kubernetes Kubernetes Stalled Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants