Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stormshield] Fix timestamp fields, move stormshield.msg to message #11177

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[stormshield] Fix timestamp fields, move stormshield.msg to message #11177

merged 2 commits into from
Sep 19, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Sep 18, 2024 •
edited
Loading

Proposed commit message

  • Use stormshield.time for @timestamp
  • Use stormshield.starttime for event.start
  • Move stormshield.msg to message
  • Release integration as GA

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/stormshield
elastic-package test

Related issues

@taylor-swanson taylor-swanson added enhancement New feature or request Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Integration:stormshield StormShield SNS labels Sep 18, 2024
@taylor-swanson taylor-swanson self-assigned this Sep 18, 2024
@taylor-swanson
[stormshield] Fix timestamp fields, move stormshield.msg to message
00dfb05 
- Use stormshield.time for @timestamp
- Use stormshield.starttime for event.start
- Move stormshield.msg to message
- Release integration as GA
@taylor-swanson
Changelog
65c95d4
@taylor-swanson taylor-swanson force-pushed the enhance/stormshield-ga-integration branch from cb2b83c to 65c95d4 Compare September 18, 2024 15:23
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@taylor-swanson taylor-swanson marked this pull request as ready for review September 18, 2024 17:19
@taylor-swanson taylor-swanson requested a review from a team as a code owner September 18, 2024 17:19
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@taylor-swanson taylor-swanson mentioned this pull request Sep 18, 2024
Closed
3 tasks
@taylor-swanson taylor-swanson merged commit bde6b51 into elastic:main Sep 19, 2024
5 checks passed
@taylor-swanson taylor-swanson deleted the enhance/stormshield-ga-integration branch September 19, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksmaus aleksmaus aleksmaus approved these changes

@dwhyrock dwhyrock dwhyrock approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Integration:stormshield StormShield SNS Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taylor-swanson @elasticmachine @aleksmaus @dwhyrock