-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure storage account: fix capacity and count metrics visualizations in the all dashboards #11120
azure storage account: fix capacity and count metrics visualizations in the all dashboards #11120
Conversation
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
compute_vm |
166666.67 | 100000 | -66666.67 (-40%) | 💔 |
To see the full report comment with /test benchmark fullreport
Looking at the files it all seems good, did you test all dashboards you changed or just the one you put the screenshot in the description? |
packages/azure_metrics/kibana/dashboard/azure_metrics-1a151f80-32db-11ea-a83e-25b8612d00cc.json
Outdated
Show resolved
Hide resolved
I tested all the dashboards. I'm adding a quick video tour in the description after the screenshots. |
Weird. In the PRs that migrated these visualizations to Lens, I see the data was visible:
But now the data is gone on the local environment (tested using 8.15.0). Is the difference now in the stack version or the data? @harnish-elastic, let me know if you have ideas. |
In Both PRs, IIRC the data that I used was mock. So that visualizations can atleast populate. The visualizations needs the My suggestion is to also include dashboard level filter changes (data_stream.dataset: {{value}}) in this PR. I can see no dashboard level filters present for |
Seems that is working now! I agree with @harnish-elastic you should add to all visulaisations the There are eg. Success Server Latency, Success E2E Latency, Ingress Traffic by APIName that use the azure.dimensions.api_name grouping. Those can benefit from a filter And a minor one, I see in the title the Azure Storage being repeated as a Title under Nvigation titles. Either add them in one or you can remove it. Sth like Azure Storage - Navigation File Storage Overview (same in Overview, Blob, Table and Queue) |
Add a `data_stream.dataset: azure.storage_account` filter to only include relevant documents.
Added a filter to all dashboards to only include documents from CleanShot.2024-09-19.at.12.51.55.mp4 |
I'm taking a look.
@gizas, I'm not sure I getting this correctly: can you give me a quick example (maybe editing the page in the browser for the final result)? |
/test |
FYI the package build reports for missing filters:
|
@gizas, here's my first attempt: CleanShot.2024-09-19.at.16.08.08.mp4 |
💚 Build Succeeded
History
cc @zmoog |
Quality Gate passedIssues Measures |
Oh, you're right. These are dashboards for the Azure Container Instance and Container Service integration metrics. I'll open new issues to fix them. |
Final recording before merging the PR: CleanShot.2024-09-20.at.11.46.18.mp4 |
Package azure_metrics - 1.6.6 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
Proposed commit message
Fix capacity and count metrics visualizations in the overview, blob, table, and file storage dashboards.
The capacity and count metric visualizations were missing the filter option, so they all displayed "N/A".
Here is the JSON before:
I just set the
filter.query
value with the corresponding metric:With the proper
filter.query
values are back.Checklist
changelog.yml
file.Screenshots
Before
After
Video tour of all the dashboards:
CleanShot.2024-09-13.at.12.05.38.mp4