Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure storage account: fix capacity and count metrics visualizations in the all dashboards #11120

Merged
merged 13 commits into from
Sep 20, 2024

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Sep 12, 2024

Proposed commit message

Fix capacity and count metrics visualizations in the overview, blob, table, and file storage dashboards.

The capacity and count metric visualizations were missing the filter option, so they all displayed "N/A".

Here is the JSON before:

{
  "customLabel": true,
  "dataType": "number",
  "filter": {
    "language": "kuery",
    "query": "" <————————— empty query here 👀 
  },
  "isBucketed": false,
  "label": "File Share Snapshot Size",
  "operationType": "last_value",
  "params": {
    "format": {
      "id": "bytes"
    },
    "sortField": "@timestamp"
  },
  "scale": "ratio",
  "sourceField": "azure.storage_account.file_share_snapshot_size.avg"
}

I just set the filter.query value with the corresponding metric:

{
  "customLabel": true,
  "dataType": "number",
  "filter": {
    "language": "kuery",
    "query": "azure.storage_account.file_share_snapshot_size.avg: *"
  },
  "isBucketed": false,
  "label": "File Share Snapshot Size",
  "operationType": "last_value",
  "params": {
    "format": {
      "id": "bytes"
    },
    "sortField": "@timestamp"
  },
  "scale": "ratio",
  "sourceField": "azure.storage_account.file_share_snapshot_size.avg"
}

With the proper filter.query values are back.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

Before

image

After

CleanShot 2024-09-13 at 11 14 47@2x

Video tour of all the dashboards:

CleanShot.2024-09-13.at.12.05.38.mp4

@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:azure_metrics Azure Resource Metrics labels Sep 12, 2024
@elasticmachine
Copy link

elasticmachine commented Sep 12, 2024

🚀 Benchmarks report

Package azure_metrics 👍(1) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
compute_vm 166666.67 100000 -66666.67 (-40%) 💔

To see the full report comment with /test benchmark fullreport

@zmoog zmoog added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] label Sep 13, 2024
@zmoog zmoog self-assigned this Sep 13, 2024
@zmoog zmoog changed the title azure storage account: fix Used Capacity in overview dashboard azure storage account: fix capacity and count metrics visualizations in the overview, blob, table, and file storage dashboards Sep 13, 2024
@zmoog zmoog changed the title azure storage account: fix capacity and count metrics visualizations in the overview, blob, table, and file storage dashboards azure storage account: fix capacity and count metrics visualizations in the all dashboards Sep 13, 2024
@zmoog zmoog marked this pull request as ready for review September 13, 2024 09:20
@zmoog zmoog requested a review from a team as a code owner September 13, 2024 09:20
@andrewkroh andrewkroh added the bugfix Pull request that fixes a bug issue label Sep 13, 2024
@constanca-m
Copy link
Contributor

Looking at the files it all seems good, did you test all dashboards you changed or just the one you put the screenshot in the description?

@zmoog
Copy link
Contributor Author

zmoog commented Sep 13, 2024

Looking at the files it all seems good, did you test all dashboards you changed or just the one you put the screenshot in the description?

I tested all the dashboards. I'm adding a quick video tour in the description after the screenshots.

@zmoog
Copy link
Contributor Author

zmoog commented Sep 13, 2024

Weird.

In the PRs that migrated these visualizations to Lens, I see the data was visible:

But now the data is gone on the local environment (tested using 8.15.0). Is the difference now in the stack version or the data?

@harnish-elastic, let me know if you have ideas.

@harnish-elastic
Copy link
Contributor

harnish-elastic commented Sep 16, 2024

Weird.

In the PRs that migrated these visualizations to Lens, I see the data was visible:

But now the data is gone on the local environment (tested using 8.15.0). Is the difference now in the stack version or the data?

@harnish-elastic, let me know if you have ideas.

In Both PRs, IIRC the data that I used was mock. So that visualizations can atleast populate. The visualizations needs the filter.query that you have set in this PR. For that GTG.

My suggestion is to also include dashboard level filter changes (data_stream.dataset: {{value}}) in this PR. I can see no dashboard level filters present for azure_metrics-1a151f80-32db-11ea-a83e-25b8612d00cc.json. If you can also add those, that would be great.

@gizas
Copy link
Contributor

gizas commented Sep 16, 2024

Seems that is working now! I agree with @harnish-elastic you should add to all visulaisations the data_stream.dataset : azure.storage_account filter (and to the other dashboard metrics the relevant filter as well)

There are eg. Success Server Latency, Success E2E Latency, Ingress Traffic by APIName that use the azure.dimensions.api_name grouping. Those can benefit from a filter azure.dimensions.api_name: * as well

And a minor one, I see in the title the Azure Storage being repeated as a Title under Nvigation titles. Either add them in one or you can remove it. Sth like Azure Storage - Navigation File Storage Overview (same in Overview, Blob, Table and Queue)

Screenshot 2024-09-16 at 10 53 01 AM

@zmoog zmoog enabled auto-merge (squash) September 19, 2024 09:01
@zmoog zmoog disabled auto-merge September 19, 2024 09:01
Add a `data_stream.dataset: azure.storage_account` filter to only
include relevant documents.
@zmoog
Copy link
Contributor Author

zmoog commented Sep 19, 2024

I agree with @harnish-elastic you should add to all visulaisations the data_stream.dataset : azure.storage_account filter (and to the other dashboard metrics the relevant filter as well)

Added a filter to all dashboards to only include documents from data_stream.dataset: azure.storage_account.

CleanShot.2024-09-19.at.12.51.55.mp4

@zmoog
Copy link
Contributor Author

zmoog commented Sep 19, 2024

There are eg. Success Server Latency, Success E2E Latency, Ingress Traffic by APIName that use the azure.dimensions.api_name grouping. Those can benefit from a filter azure.dimensions.api_name: * as well

I'm taking a look.

And a minor one, I see in the title the Azure Storage being repeated as a Title under Nvigation titles. Either add them in one or you can remove it. Sth like Azure Storage - Navigation File Storage Overview (same in Overview, Blob, Table and Queue)

@gizas, I'm not sure I getting this correctly: can you give me a quick example (maybe editing the page in the browser for the final result)?

@zmoog
Copy link
Contributor Author

zmoog commented Sep 19, 2024

/test

@gizas
Copy link
Contributor

gizas commented Sep 19, 2024

It is really minor:

If you want you can edit the settings of visualisation:
Screenshot 2024-09-19 at 4 02 42 PM

And then remove in markdown the title, so as final result:

Screenshot 2024-09-19 at 4 03 10 PM

Maybe is cleaner

@gizas
Copy link
Contributor

gizas commented Sep 19, 2024

FYI the package build reports for missing filters:

elastic-package build
2024/09/19 15:24:16  INFO New version is available - v0.104.0. Download from: https://github.com/elastic/elastic-package/releases/tag/v0.104.0
Build the package
...
2024/09/19 15:24:16  INFO Skipped errors: found 2 validation errors:
   1. file "/Users/andreasgkizas/elastic/integrations/build/packages/azure_metrics-1.6.6.zip/kibana/dashboard/azure_metrics-9c11ac60-6cf6-11ea-8fe8-71add5fd7c38.json" is invalid: expected filter in dashboard: no filter found and at least one panel does not have a filter (SVR00002)
   2. file "/Users/andreasgkizas/elastic/integrations/build/packages/azure_metrics-1.6.6.zip/kibana/dashboard/azure_metrics-dae20ed0-6d0a-11ea-8fe8-71add5fd7c38.json" is invalid: expected filter in dashboard: no filter found and at least one panel does not have a filter (SVR00002)
Package built: /Users/andreasgkizas/elastic/integrations/build/packages/azure_metrics-1.6.6.zip

@zmoog
Copy link
Contributor Author

zmoog commented Sep 19, 2024

@gizas, here's my first attempt:

CleanShot.2024-09-19.at.16.08.08.mp4

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @zmoog

@zmoog
Copy link
Contributor Author

zmoog commented Sep 19, 2024

FYI the package build reports for missing filters:

Oh, you're right.

These are dashboards for the Azure Container Instance and Container Service integration metrics. I'll open new issues to fix them.

@zmoog
Copy link
Contributor Author

zmoog commented Sep 20, 2024

Final recording before merging the PR:

CleanShot.2024-09-20.at.11.46.18.mp4

@zmoog zmoog merged commit c7d87fc into elastic:main Sep 20, 2024
5 checks passed
@zmoog zmoog deleted the zmoog/fix-azure-storage-account-dashboard branch September 20, 2024 09:52
@elastic-vault-github-plugin-prod

Package azure_metrics - 1.6.6 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:azure_metrics Azure Resource Metrics Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants