-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cisco_aironet: add ECS mapping for event.severity #11105
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline test is failing because it is expecting event.severity
to be a long
but is currently a string. We could either add a type annotation to the grok or add a convert processor. I don't have strong opinions either way.
- grok:
field: _temp_.full_message
ignore_failure: true
patterns:
- "%{DATA:event.provider}-%{INT:event.severity:long}-%{DATA:event.action}: %{DATA}:%{INT} %{GREEDYDATA:message}"
- "%{DATA:event.provider}-%{INT:event.severity:long}-%{DATA:event.action}: %{GREEDYDATA:message}"
Once that change is made, sample_event and readme also have to be regenerated.
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
[git-generate] cd packages/cisco_aironet elastic-package test pipeline -g && elastic-package test system -v -g && elastic-package build
…gs-event-severity
🚀 Benchmarks reportTo see the full report comment with |
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
cc @zmoog |
@taylor-swanson Can you please take another look. I addressed your comment in b0f92da. |
Proposed commit message
Add ECS mapping for the
event.severity
field.If a field has a string value, Elasticsearch maps it as a
keyword
. This happens even on stack versions 8.13+ because ecs@mappings does not perform type coercion.According to the
sample_event.json
file, theevent.severity
field has a string value, so Elasticsearch maps it as akeyword
instead of along
:By adding the
event.severity
field to the filefields/ecs.yml
we ensure it has the expected ECS mapping.IMPORTANT: To fully resolve the issue, the input/integration owner should update it so that they can use the expected value to leverage ecs@mappings.
Checklist
changelog.yml
file.Related issues