Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate missing commuinity_id attributes for Cisco and Sophos devices #11067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gogochan
Copy link
Contributor

@gogochan gogochan commented Sep 10, 2024

Proposed commit message

This PR fixes the pipeline failure by populating community_id attributes.

This change only works with 8.16.0. We can merge when it is ready.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Sep 10, 2024

💔 Build Failed

Failed CI Steps

History

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@gogochan gogochan marked this pull request as ready for review September 11, 2024 20:40
@gogochan gogochan requested a review from a team as a code owner September 11, 2024 20:40
@gogochan
Copy link
Contributor Author

gogochan commented Sep 11, 2024

Confirmed that payload update makes the test pass with stack version 8.16.0-SNAPSHOT

2024/09/11 16:39:02  WARN CommitHash is undefined, in both /home/ckim/.elastic-package/version and the compiled binary, config may be out of date.
2024/09/11 16:39:02  INFO New version is available - v0.104.0. Download from: https://github.com/elastic/elastic-package/releases/tag/v0.104.0
Run test suite for the package
Run asset tests for the package
2024/09/11 16:39:02  INFO License text found in "/home/ckim/repos/integrations/LICENSE.txt" will be included in package
--- Test results for package: cisco_ios - START ---
╭───────────┬─────────────┬───────────┬─────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE   │ DATA STREAM │ TEST TYPE │ TEST NAME                                           │ RESULT │ TIME ELAPSED │
├───────────┼─────────────┼───────────┼─────────────────────────────────────────────────────┼────────┼──────────────┤
│ cisco_ios │ log         │ asset     │ index_template logs-cisco_ios.log is loaded         │ PASS   │      1.073µs │
│ cisco_ios │ log         │ asset     │ ingest_pipeline logs-cisco_ios.log-1.27.1 is loaded │ PASS   │        170ns │
╰───────────┴─────────────┴───────────┴─────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: cisco_ios - END   ---
Done
Run pipeline tests for the package
--- Test results for package: cisco_ios - START ---
╭───────────┬─────────────┬───────────┬───────────────────────────────┬────────┬──────────────╮
│ PACKAGE   │ DATA STREAM │ TEST TYPE │ TEST NAME                     │ RESULT │ TIME ELAPSED │
├───────────┼─────────────┼───────────┼───────────────────────────────┼────────┼──────────────┤
│ cisco_ios │ log         │ pipeline  │ test-asr920.log               │ PASS   │  45.400955ms │
│ cisco_ios │ log         │ pipeline  │ test-badauth.log              │ PASS   │    7.39706ms │
│ cisco_ios │ log         │ pipeline  │ test-cisco-ios.log            │ PASS   │  36.844464ms │
│ cisco_ios │ log         │ pipeline  │ test-date-format-tzoffset.log │ PASS   │  23.239733ms │
│ cisco_ios │ log         │ pipeline  │ test-date-format.log          │ PASS   │  14.770893ms │
│ cisco_ios │ log         │ pipeline  │ test-syslog-header.log        │ PASS   │  11.839737ms │
│ cisco_ios │ log         │ pipeline  │ test-syslog.log               │ PASS   │  14.610777ms │
│ cisco_ios │ log         │ pipeline  │ test-tzoffset.log             │ PASS   │   2.680097ms │
│ cisco_ios │ log         │ pipeline  │ test-yearfirst-timestamp.log  │ PASS   │   6.163977ms │
╰───────────┴─────────────┴───────────┴───────────────────────────────┴────────┴──────────────╯
--- Test results for package: cisco_ios - END   ---
Done
Run static tests for the package
--- Test results for package: cisco_ios - START ---
╭───────────┬─────────────┬───────────┬──────────────────────────┬────────┬──────────────╮
│ PACKAGE   │ DATA STREAM │ TEST TYPE │ TEST NAME                │ RESULT │ TIME ELAPSED │
├───────────┼─────────────┼───────────┼──────────────────────────┼────────┼──────────────┤
│ cisco_ios │ log         │ static    │ Verify sample_event.json │ PASS   │  62.010127ms │
╰───────────┴─────────────┴───────────┴──────────────────────────┴────────┴──────────────╯
--- Test results for package: cisco_ios - END   ---
Done
Run system tests for the package
2024/09/11 16:39:31  INFO License text found in "/home/ckim/repos/integrations/LICENSE.txt" will be included in package
2024/09/11 16:40:26  INFO Write container logs to file: /home/ckim/repos/integrations/build/container-logs/cisco-logfile-1726087226905019574.log
2024/09/11 16:40:28  INFO License text found in "/home/ckim/repos/integrations/LICENSE.txt" will be included in package
2024/09/11 16:41:16  INFO Write container logs to file: /home/ckim/repos/integrations/build/container-logs/cisco-ios-tls-1726087276062801471.log
2024/09/11 16:41:17  INFO License text found in "/home/ckim/repos/integrations/LICENSE.txt" will be included in package
2024/09/11 16:42:06  INFO Write container logs to file: /home/ckim/repos/integrations/build/container-logs/cisco-ios-tcp-1726087326243178229.log
2024/09/11 16:42:08  INFO License text found in "/home/ckim/repos/integrations/LICENSE.txt" will be included in package
2024/09/11 16:42:57  INFO Write container logs to file: /home/ckim/repos/integrations/build/container-logs/cisco-ios-udp-1726087377416111889.log
--- Test results for package: cisco_ios - START ---
╭───────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE   │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├───────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ cisco_ios │ log         │ system    │ logfile   │ PASS   │ 47.051601176s │
│ cisco_ios │ log         │ system    │ tls       │ PASS   │ 36.310524935s │
│ cisco_ios │ log         │ system    │ tcp       │ PASS   │ 37.136840896s │
│ cisco_ios │ log         │ system    │ udp       │ PASS   │  37.99557833s │
╰───────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: cisco_ios - END   ---
Done

@andrewkroh andrewkroh added the Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] label Sep 11, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:cisco_ios Cisco IOS Integration:sophos Sophos Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants