Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentinel_one: document alert data stream environment limitation #11036

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 8, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:sentinel_one SentinelOne Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Sep 8, 2024
@efd6 efd6 self-assigned this Sep 8, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review September 9, 2024 00:08
@efd6 efd6 requested a review from a team as a code owner September 9, 2024 00:08
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh andrewkroh added the bugfix Pull request that fixes a bug issue label Sep 9, 2024
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit.
LGTM 👍🏼

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.25.1"
changes:
- description: Document limitation for using the alert data stream in on-primises environments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Document limitation for using the alert data stream in on-primises environments.
- description: Document limitation for using the alert data stream in on-premises environments.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit 3e5e8a1 into elastic:main Sep 11, 2024
5 checks passed
@elasticmachine
Copy link

Package sentinel_one - 1.25.1 containing this change is available at https://epr.elastic.co/search?package=sentinel_one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:sentinel_one SentinelOne Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SentinelOne]: sentinel_one.alerts dataset not supported by on-premise console
4 participants