Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_bedrock: support newer guardrails data structure #11021

Merged
merged 1 commit into from
Sep 11, 2024
Merged

aws_bedrock: support newer guardrails data structure #11021

merged 1 commit into from
Sep 11, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 5, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Integration:aws_bedrock AWS Bedrock labels Sep 5, 2024
@efd6 efd6 self-assigned this Sep 5, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
4.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review September 5, 2024 21:52
@efd6 efd6 requested a review from a team as a code owner September 5, 2024 21:52
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

shashank-elastic
shashank-elastic approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@shashank-elastic shashank-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified e.stop_reason == 'guardrail_intervened' is as expected from the original event.

@shashank-elastic
Copy link
Contributor

Fix testing details updated here

@efd6 efd6 merged commit 84d71ee into elastic:main Sep 11, 2024
4 of 5 checks passed
@elasticmachine
Copy link

Package aws_bedrock - 0.7.0 containing this change is available at https://epr.elastic.co/search?package=aws_bedrock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@shashank-elastic shashank-elastic shashank-elastic approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:aws_bedrock AWS Bedrock Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS Bedrock]: Field Mapping Issues
4 participants
@efd6 @elasticmachine @shashank-elastic @kcreddy