Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entityanalytics_entra_id: add support for request trace logging #10765

Merged
merged 2 commits into from
Sep 11, 2024
Merged

entityanalytics_entra_id: add support for request trace logging #10765

merged 2 commits into from
Sep 11, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 12, 2024 •
edited
Loading

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:entityanalytics_entra_id Microsoft Entra ID Entity Analytics Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Aug 12, 2024
@efd6 efd6 self-assigned this Aug 12, 2024
@efd6 efd6 force-pushed the 10498-entityanalytics_entra_id branch from c1d4a87 to 6721ae1 Compare August 12, 2024 08:35
@efd6 efd6 mentioned this pull request Aug 12, 2024
Merged
6 tasks
@mergify mergify bot mentioned this pull request Aug 13, 2024
Merged
6 tasks
@efd6 efd6 force-pushed the 10498-entityanalytics_entra_id branch from 6721ae1 to db14961 Compare August 13, 2024 04:43
@efd6 efd6 force-pushed the 10498-entityanalytics_entra_id branch from db14961 to b55b54a Compare September 5, 2024 20:37
@elasticmachine
Copy link

elasticmachine commented Sep 5, 2024 •
edited
Loading

🚀 Benchmarks report

Package entityanalytics_entra_id 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
entity 12987.01 10309.28 -2677.73 (-20.62%) 💔

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review September 5, 2024 21:12
@efd6 efd6 requested a review from a team as a code owner September 5, 2024 21:12
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Suggestions

packages/entityanalytics_entra_id/data_stream/entity/manifest.yml Outdated
multi: false
required: false
show_user: false
description: The request tracer logs requests and responses to the agent's local file-system for debugging configurations. Enabling this request tracing compromises security and should only be used for debugging. See [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-cel.html#_resource_tracer_filename) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly add link from Entity Analytics input?
https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-entity-analytics.html#_tracer_enabled

packages/entityanalytics_entra_id/data_stream/entity/agent/stream/entity-analytics.yml.hbs
Comment on lines +4 to +5
tracer.maxbackups: 5
tracer.maxsize: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tracer.maxbackups and tracer.maxsize are undocumented in the input. We could maybe document them.
https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-entity-analytics.html#_tracer_enabled

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit f1f0e8d into elastic:main Sep 11, 2024
5 checks passed
@elasticmachine
Copy link

Package entityanalytics_entra_id - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_entra_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:entityanalytics_entra_id Microsoft Entra ID Entity Analytics Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

entityanalytics_{okta,entra_id} - Add request tracer config option for 8.15
3 participants
@efd6 @elasticmachine @kcreddy