Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] change secret value for gcp json blob to true #10479

Merged
merged 2 commits into from
Sep 11, 2024
Merged

[Cloud Security] change secret value for gcp json blob to true #10479

merged 2 commits into from
Sep 11, 2024

Conversation

animehart
Copy link
Contributor

Description
With the Changes made on JSON Blob text area, we need to update the manifest file in order to make the secret component for the GCP Json blob to work properly.

@animehart animehart requested a review from a team as a code owner July 12, 2024 22:02
@animehart animehart changed the title [Cloud Security] Switch secret value for gcp json blob to true [Cloud Security] change secret value for gcp json blob to true Jul 12, 2024
@animehart animehart mentioned this pull request Jul 12, 2024
Merged
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

kfirpeled
kfirpeled previously approved these changes Jul 14, 2024
View reviewed changes
kfirpeled
kfirpeled reviewed Jul 16, 2024
View reviewed changes
packages/cloud_security_posture/changelog.yml Outdated
@@ -9,6 +9,11 @@
# 1.4.x - 8.9.x
# 1.3.x - 8.8.x
# 1.2.x - 8.7.x
- version: "1.10.0-preview04"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should to be 1.11.0

@animehart animehart marked this pull request as draft July 16, 2024 16:22
@kfirpeled kfirpeled dismissed their stale review July 16, 2024 16:22

changed back to draft

@andrewkroh andrewkroh added Integration:cloud_security_posture Security Posture Management Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] labels Jul 19, 2024
@botelastic
Copy link

botelastic bot commented Aug 18, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 18, 2024
@maxcold
Copy link
Contributor

maxcold commented Aug 19, 2024

@kfirpeled @animehart should we close it and reopen if needed?

@botelastic botelastic bot removed the Stalled label Aug 19, 2024
andrewkroh
andrewkroh reviewed Aug 20, 2024
View reviewed changes
packages/cloud_security_posture/changelog.yml Outdated
changes:
- description: Change gcp.credentials.json secret to true
type: enhancement
link: https://github.com/elastic/integrations/pull/9828
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/9828
link: https://github.com/elastic/integrations/pull/10479

@animehart animehart marked this pull request as ready for review September 11, 2024 19:28
@animehart
Copy link
Contributor Author

@maxcold sorry I missed your comment, seems like I forgot about this PR.
just updated it (addressing comments and conflicts) should be good now

Omolola-Akinleye
Omolola-Akinleye approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Changes were made! Thank you

@andrewkroh andrewkroh added the enhancement New feature or request label Sep 11, 2024
@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@animehart animehart merged commit ec916ab into elastic:main Sep 11, 2024
5 checks passed
@elasticmachine
Copy link

Package cloud_security_posture - 1.11.0-preview08 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh left review comments

@kfirpeled kfirpeled kfirpeled left review comments

@Omolola-Akinleye Omolola-Akinleye Omolola-Akinleye approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:cloud_security_posture Security Posture Management Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@animehart @elasticmachine @maxcold @andrewkroh @Omolola-Akinleye @kfirpeled