Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditd: Fix invalid event.type: stop->end #10090

Merged
merged 2 commits into from
Jul 7, 2024
Merged

auditd: Fix invalid event.type: stop->end #10090

merged 2 commits into from
Jul 7, 2024

Conversation

haesbaert
Copy link
Contributor

@haesbaert haesbaert commented Jun 6, 2024

Proposed commit message

stop is not a valid event.type, use end where applicable.

https://www.elastic.co/guide/en/ecs/current/ecs-allowed-values-event-type.html#ecs-event-type-end

Related to: https://github.com/elastic/sdh-beats/issues/4763

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

I've tested with elastic-package, and run the tests for the respective package.

Related issues

Related to: https://github.com/elastic/sdh-beats/issues/4763

Screenshots

Screenshot from 2024-06-06 15-02-43

@haesbaert haesbaert added the bugfix Pull request that fixes a bug issue label Jun 6, 2024
@haesbaert haesbaert marked this pull request as ready for review June 6, 2024 13:11
@haesbaert haesbaert requested a review from a team as a code owner June 6, 2024 13:11
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@haesbaert Would you mind creating an issue to fix go-libaudit please? I see it has stop.

@botelastic
Copy link

botelastic bot commented Jul 6, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 6, 2024
@haesbaert haesbaert merged commit af56b28 into main Jul 7, 2024
5 checks passed
@elasticmachine
Copy link

Package auditd - 3.19.2 containing this change is available at https://epr.elastic.co/search?package=auditd

@andrewkroh andrewkroh added the Integration:auditd Auditd Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:auditd Auditd Logs Stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants