This repository was archived by the owner on May 16, 2023. It is now read-only.
Add warning comment placeholder (7.9 branch) #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI, the expected workflow is to create the PR against main branch, then to backport it on |
jmlrt
reviewed
Nov 4, 2020
apm-server/README.md
Outdated
| SLA of official GA features (see [supported configurations][] for more details). | ||
|
|
||
| **Warning**: This branch is used for development, please use the latest [7.x][] release for released version. | ||
| <!-- development warning -->**Warning**: This branch is used for development, please use the latest [7.x][] release for released version. |
There was a problem hiding this comment.
<!-- development warning placeholder -->
**Warning**: This branch is used for development, please use the latest [7.x][] release for released version.
I have 2 suggestions:
- maybe add "placeholder" in the markdown comment to make it more explicit what it is, especially when the warning is removed in released version
- maybe move placeholder comment and warning statements on different lines to fix the markdown format issue
|
jenkins test this please |
nkammah
added a commit
to nkammah/helm-charts
that referenced
this pull request
Nov 5, 2020
nkammah
added a commit
to nkammah/helm-charts
that referenced
this pull request
Nov 5, 2020
This was referenced Nov 5, 2020
nkammah
added a commit
that referenced
this pull request
Nov 5, 2020
nkammah
added a commit
that referenced
this pull request
Nov 5, 2020
galina-tochilkin
pushed a commit
to mtp-devops/3d-party-helm
that referenced
this pull request
Dec 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The development warning comment will help with the automation.
I will backport the PR against
6.8, main branch,7.xonce this one is reviewed and merged.