Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Conversation

@fatmcgav
Copy link
Contributor

@fatmcgav fatmcgav commented Jul 7, 2020

If the --namespace flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the .Release.Namespace to resolve to default

If the `--namespace` flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the `.Release.Namespace` to resolve to `default`
@fatmcgav fatmcgav requested review from Conky5, Crazybus, jmlrt and mgreau July 7, 2020 16:21
@fatmcgav fatmcgav self-assigned this Jul 7, 2020
@fatmcgav
Copy link
Contributor Author

fatmcgav commented Jul 7, 2020

This came up from #702 (comment)

Copy link

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatmcgav fatmcgav merged commit fbfef43 into master Jul 8, 2020
@fatmcgav fatmcgav deleted the helm_namespace_default branch July 8, 2020 08:44
fatmcgav pushed a commit that referenced this pull request Jul 8, 2020
)

If the `--namespace` flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the `.Release.Namespace` to resolve to `default`
fatmcgav pushed a commit that referenced this pull request Jul 8, 2020
)

If the `--namespace` flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the `.Release.Namespace` to resolve to `default`
fatmcgav pushed a commit that referenced this pull request Jul 8, 2020
)

If the `--namespace` flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the `.Release.Namespace` to resolve to `default`
This was referenced Jul 16, 2020
This was referenced Jul 27, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants